From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.8774.1675426271823073355 for ; Fri, 03 Feb 2023 04:11:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c8u1GIAA; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8F6DFB82A72; Fri, 3 Feb 2023 12:11:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBB4DC433EF; Fri, 3 Feb 2023 12:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675426268; bh=ArJ5NejspI+rAI/X80v1lGpQu16+Xz7iVqfVIza2o3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c8u1GIAApm2lzmVAoBhIyGpyT+ehIXnaYY4eFdL5Jwj5soYB02Zco92u2vab1562G kmzGQHEkM7xIlWxO8qMJkpcDd5cX3CWPU5mbkmvtZ/OgIaNL02qKzO9SB26Z2ljawM OAeiHMK9V4LD7L34iBImCPBmZrdWbHAYkf9trDTv2/IQTer0tzJhXdJXZ/RUP/nDTR zSm+mapwb4syMQ4z4hq3QrUFDVHcrbNkNk5KCGFY7QGtIXF1EhpHLU3fVpr02RP1E0 /0csi3bFUG8qqTti6sWnh+8Ndla51DvUG7LehBtJ3HSX28agC6n28gdlhJsNRwTWU7 MDNMdT1kuO+Vw== From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Michael Kinney , Liming Gao , Jiewen Yao , Michael Kubacki , Sean Brogan , Rebecca Cran , Leif Lindholm , Sami Mujawar , Taylor Beebe , =?UTF-8?q?Marvin=20H=C3=A4user?= Subject: [RFC PATCH v2 3/7] MdePkg/BasePeCoffLib: Clean up stale Itanium references in comments Date: Fri, 3 Feb 2023 13:10:25 +0100 Message-Id: <20230203121029.2451394-4-ardb@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230203121029.2451394-1-ardb@kernel.org> References: <20230203121029.2451394-1-ardb@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable The specialized relocation fixup handlers are used by ARM and RISC-V but not by IPF/Itanium anymore, so let's clean up the comments referring to Itanium. No code changes. Signed-off-by: Ard Biesheuvel --- MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 2 +- MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h | 8 +++----- MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c | 11 +++++------ 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c b/MdePkg/Library/Bas= ePeCoffLib/BasePeCoff.c index 97a8aaf8c73d..85ada399e303 100644 --- a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c +++ b/MdePkg/Library/BasePeCoffLib/BasePeCoff.c @@ -1901,7 +1901,7 @@ PeCoffLoaderRelocateImageForRuntime ( =0D default:=0D //=0D - // Only Itanium requires ConvertPeImage_Ex=0D + // Perform architecture/ISA specific relocation.=0D //=0D Status =3D PeHotRelocateImageEx (Reloc, Fixup, &FixupData, Adj= ust);=0D if (RETURN_ERROR (Status)) {=0D diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h b/MdePkg= /Library/BasePeCoffLib/BasePeCoffLibInternals.h index 4a43ec236529..a29a6febe98f 100644 --- a/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h +++ b/MdePkg/Library/BasePeCoffLib/BasePeCoffLibInternals.h @@ -18,8 +18,7 @@ #include =0D =0D /**=0D - Performs an Itanium-based specific relocation fixup and is a no-op on ot= her=0D - instruction sets.=0D + Performs an architecture/ISA specific relocation fixup.=0D =0D @param Reloc The pointer to the relocation record.=0D @param Fixup The pointer to the address to fix up.=0D @@ -38,9 +37,8 @@ PeCoffLoaderRelocateImageEx ( );=0D =0D /**=0D - Performs an Itanium-based specific re-relocation fixup and is a no-op on= other=0D - instruction sets. This is used to re-relocated the image into the EFI vi= rtual=0D - space for runtime calls.=0D + Performs an architecture/ISA specific re-relocation fixup. This is used = to=0D + re-relocate the image into the EFI virtual space for runtime calls.=0D =0D @param Reloc The pointer to the relocation record.=0D @param Fixup The pointer to the address to fix up.=0D diff --git a/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c b/MdePkg/Library= /BasePeCoffLib/PeCoffLoaderEx.c index 1a806dd62db6..f7cade4d7d4e 100644 --- a/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c +++ b/MdePkg/Library/BasePeCoffLib/PeCoffLoaderEx.c @@ -1,5 +1,6 @@ /** @file=0D - Specific relocation fixups for none Itanium architecture.=0D + NULL implementations of architecture/ISA Specific relocation handlers,=0D + for architectures/ISAs that only use the generic PE/COFF relocation type= s.=0D =0D Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
=0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D @@ -9,8 +10,7 @@ #include "BasePeCoffLibInternals.h"=0D =0D /**=0D - Performs an Itanium-based specific relocation fixup and is a no-op on ot= her=0D - instruction sets.=0D + Performs an architecture/ISA specific relocation fixup.=0D =0D @param Reloc The pointer to the relocation record.=0D @param Fixup The pointer to the address to fix up.=0D @@ -59,9 +59,8 @@ PeCoffLoaderImageFormatSupported ( }=0D =0D /**=0D - Performs an Itanium-based specific re-relocation fixup and is a no-op on= other=0D - instruction sets. This is used to re-relocated the image into the EFI vi= rtual=0D - space for runtime calls.=0D + Performs an architecture/ISA specific re-relocation fixup. This is used = to=0D + re-relocate the image into the EFI virtual space for runtime calls.=0D =0D @param Reloc The pointer to the relocation record.=0D @param Fixup The pointer to the address to fix up.=0D --=20 2.39.1