From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, ardb@kernel.org
Cc: Min Xu <min.m.xu@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Michael Roth <michael.roth@amd.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Oliver Steffen <osteffen@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Xiaoyu Lu <xiaoyu1.lu@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
Guomin Jiang <guomin.jiang@intel.com>,
James Bottomley <jejb@linux.ibm.com>
Subject: Re: [edk2-devel] [PATCH 00/11] OvmfPkg: add Crypto Driver support
Date: Fri, 3 Feb 2023 16:36:54 +0100 [thread overview]
Message-ID: <20230203153654.pyutijc54a66pe6e@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAMj1kXEHvSzrQQSFi2LsJ10beJRacjjPQgCTB4UkK1iCJc2BOg@mail.gmail.com>
On Fri, Feb 03, 2023 at 02:33:07PM +0100, Ard Biesheuvel wrote:
> What is the point of this series? If we are trying to deduplicate
> crypto code by moving it into a dedicated driver, can we please just
> do that unconditionally, instead of doubling the size of the
> validation matrix again? Or are there reasons why one might avoid this
> crypto driver approach?
Unfortunately it is not a clear size win everywhere.
PEI jumps up in size even though I'm using the min_pei config for
CryptoPei, seems it *still* has way too much bits compiled in
(didn't look into tweaking the config yet, hints are welcome).
- 17530 TcgPei
+ 17146 TcgPei
+ 34362 Tcg2Pei
- 51066 Tcg2Pei
+ 333950 CryptoPei
SMM doesn't change much (slight increase):
+ 106662 VariableSmm
- 540818 VariableSmm
+ 479374 CryptoSmm
DXE is a clear win, three users go from > 400k to < 100k which easily
compensates for the almost 700k crypto driver:
+ 17326 TlsDxe
- 19494 TcgDxe
+ 19450 TcgDxe
+ 36682 SecurityStubDxe
+ 54630 Tcg2Dxe
- 68498 Tcg2Dxe
+ 78898 SecureBootConfigDxe
+ 121190 IScsiDxe
- 125174 IScsiDxe
- 404574 SecureBootConfigDxe
- 479414 SecurityStubDxe
- 667006 TlsDxe
+ 696298 CryptoDxe
Overall it should still be a (small) win even without looking at why PEI
is so big.
If there are no objections I happily drop the USE_CRYPTO_DRIVER option
and switch over to the crypto driver unconditionally.
take care,
Gerd
next prev parent reply other threads:[~2023-02-03 15:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:27 [PATCH 00/11] OvmfPkg: add Crypto Driver support Gerd Hoffmann
2023-02-03 13:27 ` [PATCH 01/11] CryptoPkg: move Driver PCD configs to include files Gerd Hoffmann
2023-02-03 13:27 ` [PATCH 02/11] OvmfPkg: add OvmfCryptoLibs.dsc.inc Gerd Hoffmann
2023-02-03 13:27 ` [PATCH 03/11] OvmfPkg: OvmfPkgX64: use Crypto Libs include Gerd Hoffmann
2023-02-03 13:27 ` [PATCH 04/11] OvmfPkg: Add Crypto driver support, add more OvmfCrypto*.inc files Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 05/11] OvmfPkg: OvmfPkgX64: use new Crypto support includes Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 06/11] OvmfPkg: add OVMF_X64_CRYPTO_DRIVER test case Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 07/11] OvmfPkg: OvmfPkgIa32X64: use crypto includes Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 08/11] OvmfPkg: OvmfPkgIa32: " Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 09/11] OvmfPkg: Microvm: " Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 10/11] OvmfPkg: IntelTdx: " Gerd Hoffmann
2023-02-03 13:28 ` [PATCH 11/11] OvmfPkg: AmdSev: " Gerd Hoffmann
2023-02-03 13:33 ` [PATCH 00/11] OvmfPkg: add Crypto Driver support Ard Biesheuvel
2023-02-03 15:36 ` Gerd Hoffmann [this message]
2023-02-03 15:57 ` [edk2-devel] " Ard Biesheuvel
2023-02-03 16:28 ` Gerd Hoffmann
2023-02-03 19:45 ` Pedro Falcato
2023-02-03 23:24 ` Ard Biesheuvel
2023-02-04 1:08 ` Pedro Falcato
2023-02-04 7:56 ` Ard Biesheuvel
2023-02-04 1:13 ` Marvin Häuser
2023-02-04 8:05 ` Ard Biesheuvel
2023-02-04 9:58 ` Marvin Häuser
2023-02-04 8:10 ` Ard Biesheuvel
2023-02-06 8:21 ` Gerd Hoffmann
2023-02-07 3:15 ` Li, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203153654.pyutijc54a66pe6e@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox