From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.15420.1675441732635098168 for ; Fri, 03 Feb 2023 08:28:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iLwVfvDZ; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675441731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PGAFhbnMPs6ZBNSQXvAtmYTlmGwsrYEbLHyb6gLqOJA=; b=iLwVfvDZJDBynnSxiBYnDG0ytqypodTfb1Fvo+wGiyQ/fDxrc+QZ7ycpXK644FgwHuEGWS J5z1TH7n0tzG6iLvh/vFVEiT7wex5WJ8bX58C9g3aXbOYQTJg9Wd8O5cXVDs307EMp6xA4 Npru4e9iorKdjKNyqljtcaIcPL3xW8g= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-217-RUKVOd2BMKmzCnNcaj6SSw-1; Fri, 03 Feb 2023 11:28:47 -0500 X-MC-Unique: RUKVOd2BMKmzCnNcaj6SSw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 31C961C05B0F; Fri, 3 Feb 2023 16:28:46 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EE8BE492B15; Fri, 3 Feb 2023 16:28:45 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 52996180060E; Fri, 3 Feb 2023 17:28:44 +0100 (CET) Date: Fri, 3 Feb 2023 17:28:44 +0100 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Min Xu , Ard Biesheuvel , Michael Roth , Jiewen Yao , Jian J Wang , Jordan Justen , Pawel Polawski , Oliver Steffen , Tom Lendacky , Xiaoyu Lu , Erdem Aktas , Guomin Jiang , James Bottomley Subject: Re: [edk2-devel] [PATCH 00/11] OvmfPkg: add Crypto Driver support Message-ID: <20230203162844.gailv3rz3ia3jdpe@sirius.home.kraxel.org> References: <20230203132806.2275708-1-kraxel@redhat.com> <20230203153654.pyutijc54a66pe6e@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > > Unfortunately it is not a clear size win everywhere. > > > > PEI jumps up in size even though I'm using the min_pei config for > > CryptoPei, seems it *still* has way too much bits compiled in > > (didn't look into tweaking the config yet, hints are welcome). > > > > - 17530 TcgPei > > + 17146 TcgPei > > + 34362 Tcg2Pei > > - 51066 Tcg2Pei > > + 333950 CryptoPei > > Why would we use this for PEI if the size increases? When using the crypto driver I'd prefer to do it everywhere and don't mix+match things. Background is that I'm hoping the crypto driver abstraction can also help to have alternative drivers using other crypto libraries without creating a huge mess in CryptoPkg. Specifically add openssl-3 as an option. openssl-11 goes EOL later this year (Nov IIRC). Switch to openssl-3 unconditionally has been vetoed by Intel due to the size increase v3 brings. So I'm looking for options here ... > > If there are no objections I happily drop the USE_CRYPTO_DRIVER option > > and switch over to the crypto driver unconditionally. > > Yeah, I'd prefer that. Noted for v2 next week. take care, Gerd