From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.63]) by mx.groups.io with SMTP id smtpd.web11.87913.1675786983718830514 for ; Tue, 07 Feb 2023 08:23:03 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=bk57FdVT; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.63, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eeXtJbLQPozlkW305JXvPo3GBsq9w424M44mJOzFnkj/bwtV0/g+lDlGXkCt8qQupDkdMm5YrHEASAadT2eA//fjq2DoerfN3b4IksmC/IuT6EKkg9x0PBgdC75idI6so08CABhbGUc64Jp+AKGqCxVC4dLJB4mDjBn3FB/dlfw/XH5zY1S2UTZ2W6VCUf9UakfZ+Io/tQTlibziKhWBNlKPn+a+uFuFtMY3nRdaWs3zVKGveULr5BO1uHRPMWgyRrpqQVyUg6UhpkUoYt6rnLvjyq2ZZTTm6MlPc5sguRSEws1OI6hjF5AK717HUYEMT8e083wf5sChYAe9GcllFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3vw+n8dXK4CTb1VME3Fm5fvihsMqOqyLpwt5eWx+UNM=; b=JLjBLxtd1dapGpn6Uyg16ThrWJL/UAovYqcLkCtSYipTnRUmn2lkVsK7b0J7jksMe6GN3VzjiDPf1d1a5IbUsvXX5DpWts3x3byqjEjHwRcEVgsGiLvFBZwu5sY9eYqeueqNuAV/PEQ/XbyKBpOeU3ZJMeAADQKq2ArAkLDARW0+uzH6jUAG9VrIk1QKFZjxSQSobNF9b7avNIY+FYhcarRPn9EcEg4+rxmSFn8o+XSJEwTSLDjb87TFXDdYjHVlx9AT+4UV01lxQF1srSUMJWS3YAlotUGk8FRJMQSq1pAIG6rT4Sh5eUvlVhA6rXPNkeXv2tXIQ1SzDqNVG/SUfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3vw+n8dXK4CTb1VME3Fm5fvihsMqOqyLpwt5eWx+UNM=; b=bk57FdVTQtTejwBf1oCxJHqIUlib8Hr4Nm5mQn+fJo7xTlCk4pejEExEgn3I2hO26ovvvS7LXCFEv8cZxfas70RJPjdOTnCFqFU9Rog/L0SKKWpzLtKKVz0kz3C+VTyXfO90i3+jhJJLf/vLYr4WDSUPVPAza6HMrCshL0YZzrA= Received: from MW4P221CA0009.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::14) by CY8PR12MB7707.namprd12.prod.outlook.com (2603:10b6:930:86::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 16:22:59 +0000 Received: from CO1NAM11FT037.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8b:cafe::d2) by MW4P221CA0009.outlook.office365.com (2603:10b6:303:8b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Tue, 7 Feb 2023 16:22:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT037.mail.protection.outlook.com (10.13.174.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6086.16 via Frontend Transport; Tue, 7 Feb 2023 16:22:59 +0000 Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 7 Feb 2023 10:22:57 -0600 From: "Chang, Abner" To: CC: Liming Gao , Isaac Oram , Nate DeSimone , Nickle Wang , Igor Kulchytskyy , "Abdul Lateef Attar" Subject: [edk2-platforms][PATCH 1/7] IpmiFeaturePkg: Rename IpmiSubmitCommand function Date: Wed, 8 Feb 2023 00:22:30 +0800 Message-ID: <20230207162236.1406-2-abner.chang@amd.com> X-Mailer: git-send-email 2.37.1.windows.1 In-Reply-To: <20230207162236.1406-1-abner.chang@amd.com> References: <20230207162236.1406-1-abner.chang@amd.com> MIME-Version: 1.0 Return-Path: Abner.Chang@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT037:EE_|CY8PR12MB7707:EE_ X-MS-Office365-Filtering-Correlation-Id: 672dfd9e-8e61-4a8c-b2c9-08db0927942b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BT3wjttq52WkuwgOWeF74rfL7/RI278A4VVr0wbCs97WWoihtOiQwHgdNZEInfL1gvgY1tE9/5XGU8+ffTrTuVSloRdBFSl5CKq9JNGEr/EHaKYccgQGC1Iztv2eY6ukaQIvrMoC9TxScb10/bJUoChL9mJdd31Rv7b9tEVbjdPLKp/9TC2NGHA8PYpCnRTaCLXdhAhQj4aERyWA/SmNreQgxLPPGNwvokdbXcU9eX3ND4Pt2SheEQ1gZGFASqg3YwMVNdkLC8Pca0lqzFsFZCrRr0fPmvQCJIgw+EmlE7r2FctG0ayQuC7M70bf3R0ZvHtAfSr54ZhtflaB0QfkvC48wcOAeco1ScLfV1JilRJHqFKq9jMwfZhiv8uBNOukdhu/oQ2WYHXvlQsw/seVd/xDgqvfx8+lv8Wk6n9y07ubf8SymDqqjMZMTHi6B0KUkPERcV8LpLvenW9Glg5k/dFP4xY69u3q7EqXe4HIox0SVuOL06+vJYHG/ntou2cbkdvBgxzNw6+OlIC1AHTLR/Nm8ovzCoqAJVH57m/Z4+yfVbZtBTblwevjPyGvg6OQSeWbQIE0vWDHmaggvbIkAGYldsEEqLNVhyBR/43vOjVglk0rFv8PVUjTJG4XWSIB3Cj/QAHSKFrQWIqZ+9+5q8EnkfdzLnEVFgu6nWYfOtzOb4SHkUv/40F4IdsuMsiiNT5I3ARgzzDJddv1YJcX+tgnCqrH8vXb2aXwI6DkWGw= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199018)(40470700004)(36840700001)(46966006)(4326008)(336012)(83380400001)(70206006)(47076005)(426003)(82740400003)(40460700003)(40480700001)(41300700001)(81166007)(356005)(8936002)(36860700001)(70586007)(8676002)(6916009)(2906002)(2876002)(36756003)(2616005)(30864003)(1076003)(82310400005)(26005)(16526019)(54906003)(316002)(478600001)(7696005)(186003)(6666004)(86362001)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 16:22:59.5604 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 672dfd9e-8e61-4a8c-b2c9-08db0927942b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT037.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7707 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Abner Chang Rename IpmiSubmitCommand to IpmiSendCommand because the naming of this function is confusing with IpmiSubmitCommand defined in IPMI Protocol. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef Attar --- .../Include/Library/IpmiBaseLib.h | 2 +- .../Include/Ppi/IpmiTransportPpi.h | 2 +- .../Include/Protocol/IpmiTransportProtocol.h | 2 +- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 2 +- .../GenericIpmi/Pei/PeiGenericIpmi.c | 2 +- .../GenericIpmi/Smm/SmmGenericIpmi.c | 2 +- .../Library/IpmiBaseLib/IpmiBaseLib.c | 4 +-- .../Library/IpmiBaseLibNull/IpmiBaseLibNull.c | 2 +- .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 26 +++++++++---------- .../IpmiCommandLibNetFnChassis.c | 12 ++++----- .../IpmiCommandLibNetFnStorage.c | 24 ++++++++--------- .../IpmiCommandLibNetFnTransport.c | 8 +++--- .../Library/PeiIpmiBaseLib/PeiIpmiBaseLib.c | 4 +-- .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 4 +-- .../Ipmi/Library/IpmiLibKcs/IpmiLibKcs.c | 12 ++++----- 15 files changed, 54 insertions(+), 54 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Libr= ary/IpmiBaseLib.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/Library/IpmiBaseLib.h index 8487ace5ba..9e77bdad8d 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/Ipm= iBaseLib.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/Ipm= iBaseLib.h @@ -37,7 +37,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/= IpmiTransportPpi.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Incl= ude/Ppi/IpmiTransportPpi.h index 9ecb20f9bf..4bdb5db00b 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/IpmiTra= nsportPpi.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ppi/IpmiTra= nsportPpi.h @@ -59,7 +59,7 @@ EFI_STATUS // struct _PEI_IPMI_TRANSPORT_PPI { UINT64 Revision; - PEI_IPMI_SEND_COMMAND IpmiSubmitCommand; + PEI_IPMI_SEND_COMMAND IpmiSendCommand; PEI_IPMI_GET_CHANNEL_STATUS GetBmcStatus; }; =20 diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Prot= ocol/IpmiTransportProtocol.h b/Features/Intel/OutOfBandManagement/IpmiFeatu= rePkg/Include/Protocol/IpmiTransportProtocol.h index 2ee6f98e07..bb17073f06 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/Ip= miTransportProtocol.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Protocol/Ip= miTransportProtocol.h @@ -63,7 +63,7 @@ EFI_STATUS // struct _IPMI_TRANSPORT { UINT64 Revision; - IPMI_SEND_COMMAND IpmiSubmitCommand; + IPMI_SEND_COMMAND IpmiSendCommand; IPMI_GET_CHANNEL_STATUS GetBmcStatus; EFI_HANDLE IpmiHandle; UINT8 CompletionCode; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index d788b48867..f1f089b575 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c @@ -396,7 +396,7 @@ InitializeIpmiKcsPhysicalLayer ( mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGNAT= URE; mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRESS; mIpmiInstance->BmcStatus =3D BMC_NOTREADY; - mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D IpmiSendCommand; + mIpmiInstance->IpmiTransport.IpmiSendCommand =3D IpmiSendCommand; mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus; =20 // diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Pei/PeiGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Pei/PeiGenericIpmi.c index 3efb772b68..e9018ca8df 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.c @@ -76,7 +76,7 @@ PeiInitializeIpmiKcsPhysicalLayer ( mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGNAT= URE; mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRESS; mIpmiInstance->BmcStatus =3D BMC_NOTREADY; - mIpmiInstance->IpmiTransportPpi.IpmiSubmitCommand =3D PeiIpmiSendCommand= ; + mIpmiInstance->IpmiTransportPpi.IpmiSendCommand =3D PeiIpmiSendCommand= ; mIpmiInstance->IpmiTransportPpi.GetBmcStatus =3D PeiGetIpmiBmcStatu= s; =20 mIpmiInstance->PeiIpmiBmcDataDesc.Flags =3D EFI_PEI_PPI_DESCRIPT= OR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Smm/SmmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Smm/SmmGenericIpmi.c index fda215baaa..c1892f5ab8 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/Smm= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/Smm= GenericIpmi.c @@ -166,7 +166,7 @@ Returns: mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGNAT= URE; mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRESS; mIpmiInstance->BmcStatus =3D BMC_NOTREADY; - mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D IpmiSendCommand; + mIpmiInstance->IpmiTransport.IpmiSendCommand =3D IpmiSendCommand; mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus; =20 DEBUG ((DEBUG_INFO,"IPMI: Waiting for Getting BMC DID in SMM \n")); diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= BaseLib/IpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/L= ibrary/IpmiBaseLib/IpmiBaseLib.c index 5df9d861c6..01ff322d27 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib= /IpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib= /IpmiBaseLib.c @@ -91,7 +91,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, @@ -108,7 +108,7 @@ IpmiSubmitCommand ( return Status; } =20 - Status =3D mIpmiTransport->IpmiSubmitCommand ( + Status =3D mIpmiTransport->IpmiSendCommand ( mIpmiTransport, NetFunction, 0, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= BaseLibNull/IpmiBaseLibNull.c b/Features/Intel/OutOfBandManagement/IpmiFeat= urePkg/Library/IpmiBaseLibNull/IpmiBaseLibNull.c index 7c4c67f6ac..7af21bbaf1 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib= Null/IpmiBaseLibNull.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib= Null/IpmiBaseLibNull.c @@ -43,7 +43,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= CommandLib/IpmiCommandLibNetFnApp.c b/Features/Intel/OutOfBandManagement/Ip= miFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c index 2e34909f3e..dbd154e2a6 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnApp.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnApp.c @@ -24,7 +24,7 @@ IpmiGetDeviceId ( UINT32 DataSize; =20 DataSize =3D sizeof(*DeviceId); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_DEVICE_ID, NULL, @@ -45,7 +45,7 @@ IpmiGetSelfTestResult ( UINT32 DataSize; =20 DataSize =3D sizeof(*SelfTestResult); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_SELFTEST_RESULTS, NULL, @@ -66,7 +66,7 @@ IpmiResetWatchdogTimer ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_RESET_WATCHDOG_TIMER, NULL, @@ -88,7 +88,7 @@ IpmiSetWatchdogTimer ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_SET_WATCHDOG_TIMER, (VOID *)SetWatchdogTimer, @@ -109,7 +109,7 @@ IpmiGetWatchdogTimer ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetWatchdogTimer); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_WATCHDOG_TIMER, NULL, @@ -131,7 +131,7 @@ IpmiSetBmcGlobalEnables ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_SET_BMC_GLOBAL_ENABLES, (VOID *)SetBmcGlobalEnables, @@ -152,7 +152,7 @@ IpmiGetBmcGlobalEnables ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetBmcGlobalEnables); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_BMC_GLOBAL_ENABLES, NULL, @@ -174,7 +174,7 @@ IpmiClearMessageFlags ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_CLEAR_MESSAGE_FLAGS, (VOID *)ClearMessageFlagsRequest, @@ -195,7 +195,7 @@ IpmiGetMessageFlags ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetMessageFlagsResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_MESSAGE_FLAGS, NULL, @@ -215,7 +215,7 @@ IpmiGetMessage ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_MESSAGE, NULL, @@ -237,7 +237,7 @@ IpmiSendMessage ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_SEND_MESSAGE, (VOID *)SendMessageRequest, @@ -274,7 +274,7 @@ IpmiGetSystemUuid ( } RequestSize =3D 0; ResponseSize =3D sizeof (IPMI_GET_SYSTEM_UUID_RESPONSE); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_SYSTEM_GUID, (VOID *)NULL, @@ -323,7 +323,7 @@ IpmiGetChannelInfo ( } =20 *GetChannelInfoResponseSize =3D sizeof (IPMI_GET_CHANNEL_INFO_RESPONSE); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_APP, IPMI_APP_GET_CHANNEL_INFO, (UINT8 *)GetChannelInfoRequest, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= CommandLib/IpmiCommandLibNetFnChassis.c b/Features/Intel/OutOfBandManagemen= t/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c index 9c19f52ce4..c8c0e90a79 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnChassis.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnChassis.c @@ -23,7 +23,7 @@ IpmiGetChassisCapabilities ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetChassisCapabilitiesResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_GET_CAPABILITIES, NULL, @@ -44,7 +44,7 @@ IpmiGetChassisStatus ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetChassisStatusResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_GET_STATUS, NULL, @@ -66,7 +66,7 @@ IpmiChassisControl ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_CONTROL, (VOID *)ChassisControlRequest, @@ -88,7 +88,7 @@ IpmiSetPowerRestorePolicy ( UINT32 DataSize; =20 DataSize =3D sizeof(*ChassisControlResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_SET_POWER_RESTORE_POLICY, (VOID *)ChassisControlRequest, @@ -110,7 +110,7 @@ IpmiSetSystemBootOptions ( UINT32 DataSize; =20 DataSize =3D sizeof(*BootOptionsResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_SET_SYSTEM_BOOT_OPTIONS, (VOID *)BootOptionsRequest, @@ -132,7 +132,7 @@ IpmiGetSystemBootOptions ( UINT32 DataSize; =20 DataSize =3D sizeof(*BootOptionsResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_CHASSIS, IPMI_CHASSIS_GET_SYSTEM_BOOT_OPTIONS, (VOID *)BootOptionsRequest, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= CommandLib/IpmiCommandLibNetFnStorage.c b/Features/Intel/OutOfBandManagemen= t/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c index 2215028089..4e84084605 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnStorage.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnStorage.c @@ -24,7 +24,7 @@ IpmiGetFruInventoryAreaInfo ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetFruInventoryAreaInfoResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_FRU_INVENTORY_AREAINFO, (VOID *)GetFruInventoryAreaInfoRequest, @@ -45,7 +45,7 @@ IpmiReadFruData ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_READ_FRU_DATA, (VOID *)ReadFruDataRequest, @@ -68,7 +68,7 @@ IpmiWriteFruData ( UINT32 DataSize; =20 DataSize =3D sizeof(*WriteFruDataResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_WRITE_FRU_DATA, (VOID *)WriteFruDataRequest, @@ -89,7 +89,7 @@ IpmiGetSelInfo ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetSelInfoResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SEL_INFO, NULL, @@ -110,7 +110,7 @@ IpmiGetSelEntry ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SEL_ENTRY, (VOID *)GetSelEntryRequest, @@ -132,7 +132,7 @@ IpmiAddSelEntry ( UINT32 DataSize; =20 DataSize =3D sizeof(*AddSelEntryResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_ADD_SEL_ENTRY, (VOID *)AddSelEntryRequest, @@ -155,7 +155,7 @@ IpmiPartialAddSelEntry ( UINT32 DataSize; =20 DataSize =3D sizeof(*PartialAddSelEntryResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_PARTIAL_ADD_SEL_ENTRY, (VOID *)PartialAddSelEntryRequest, @@ -177,7 +177,7 @@ IpmiClearSel ( UINT32 DataSize; =20 DataSize =3D sizeof(*ClearSelResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_CLEAR_SEL, (VOID *)ClearSelRequest, @@ -198,7 +198,7 @@ IpmiGetSelTime ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetSelTimeResponse); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SEL_TIME, NULL, @@ -220,7 +220,7 @@ IpmiSetSelTime ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_SET_SEL_TIME, (VOID *)SetSelTimeRequest, @@ -241,7 +241,7 @@ IpmiGetSdrRepositoryInfo ( UINT32 DataSize; =20 DataSize =3D sizeof(*GetSdrRepositoryInfoResp); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SDR_REPOSITORY_INFO, NULL, @@ -262,7 +262,7 @@ IpmiGetSdr ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_STORAGE, IPMI_STORAGE_GET_SDR, (VOID *)GetSdrRequest, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= CommandLib/IpmiCommandLibNetFnTransport.c b/Features/Intel/OutOfBandManagem= ent/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c index 30ea84c04b..eec281c5bd 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnTransport.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommand= Lib/IpmiCommandLibNetFnTransport.c @@ -26,7 +26,7 @@ IpmiSolActivating ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_TRANSPORT, IPMI_TRANSPORT_SOL_ACTIVATING, (VOID *)SolActivatingRequest, @@ -49,7 +49,7 @@ IpmiSetSolConfigurationParameters ( UINT32 DataSize; =20 DataSize =3D sizeof(*CompletionCode); - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_TRANSPORT, IPMI_TRANSPORT_SET_SOL_CONFIG_PARAM, (VOID *)SetConfigurationParametersRequest, @@ -70,7 +70,7 @@ IpmiGetSolConfigurationParameters ( { EFI_STATUS Status; =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_TRANSPORT, IPMI_TRANSPORT_GET_SOL_CONFIG_PARAM, (VOID *)GetConfigurationParametersRequest, @@ -111,7 +111,7 @@ IpmiGetLanConfigurationParameters ( return EFI_INVALID_PARAMETER; } =20 - Status =3D IpmiSubmitCommand ( + Status =3D IpmiSendCommand ( IPMI_NETFN_TRANSPORT, IPMI_TRANSPORT_GET_LAN_CONFIG_PARAMETERS, (UINT8 *)GetLanConfigurationParametersRequest, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiI= pmiBaseLib/PeiIpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeatur= ePkg/Library/PeiIpmiBaseLib/PeiIpmiBaseLib.c index 8679cd95db..b97152208a 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBase= Lib/PeiIpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBase= Lib/PeiIpmiBaseLib.c @@ -48,7 +48,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, @@ -65,7 +65,7 @@ IpmiSubmitCommand ( ASSERT_EFI_ERROR (Status); return Status; } - Status =3D IpmiTransport->IpmiSubmitCommand ( + Status =3D IpmiTransport->IpmiSendCommand ( IpmiTransport, NetFunction, 0, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmI= pmiBaseLib/SmmIpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeatur= ePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c index 6282adc269..ee1d3d5bed 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBase= Lib/SmmIpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBase= Lib/SmmIpmiBaseLib.c @@ -96,7 +96,7 @@ InitializeIpmiBase ( =20 **/ EFI_STATUS -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *CommandData, @@ -133,7 +133,7 @@ Returns: return Status; } =20 - Status =3D mIpmiTransport->IpmiSubmitCommand ( + Status =3D mIpmiTransport->IpmiSendCommand ( mIpmiTransport, NetFunction, 0, diff --git a/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLi= bKcs/IpmiLibKcs.c b/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library= /IpmiLibKcs/IpmiLibKcs.c index 700e413aa6..2b02ba6a20 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/Ip= miLibKcs.c +++ b/Platform/Intel/PurleyOpenBoardPkg/Features/Ipmi/Library/IpmiLibKcs/Ip= miLibKcs.c @@ -193,7 +193,7 @@ UpdateBmcStatusOnResponse ( **/ EFI_STATUS EFIAPI -IpmiSubmitCommand ( +IpmiSendCommand ( IN UINT8 NetFunction, IN UINT8 Command, IN UINT8 *RequestData, @@ -222,7 +222,7 @@ IpmiSubmitCommand ( } =20 IpmiInstance->Signature =3D SM_IPMI_BMC_SIGNATURE= ; - IpmiInstance->KcsTimeoutPeriod =3D PcdGet64(PcdIpmiKcsTi= meoutPeriod);=20 + IpmiInstance->KcsTimeoutPeriod =3D PcdGet64(PcdIpmiKcsTi= meoutPeriod); IpmiInstance->SlaveAddress =3D PcdGet8(PcdIpmiBmcSla= veAddress); IpmiInstance->IpmiIoBase =3D PcdGet16(PcdIpmiIoBas= eAddress); DEBUG((DEBUG_INFO,"IPMI KcsTimeoutPeriod=3D0x%x\n", IpmiInstance->KcsT= imeoutPeriod)); @@ -269,7 +269,7 @@ IpmiSubmitCommand ( } =20 Status =3D SendDataToBmcPort ( - IpmiInstance->KcsTimeoutPeriod, + IpmiInstance->KcsTimeoutPeriod, IpmiInstance->IpmiIoBase, (UINT8 *)IpmiCommand, (UINT8)(RequestDataSize + EFI_IPMI_COMMAND_HEADER_SIZE) @@ -287,7 +287,7 @@ IpmiSubmitCommand ( // DataSize =3D MAX_TEMP_DATA; Status =3D ReceiveBmcDataFromPort ( - IpmiInstance->KcsTimeoutPeriod, + IpmiInstance->KcsTimeoutPeriod, IpmiInstance->IpmiIoBase, (UINT8 *)IpmiResponse, &DataSize @@ -301,8 +301,8 @@ IpmiSubmitCommand ( } =20 // - // If we got this far without any error codes, but the DataSize is 0 the= n the=20 - // command response failed, so do not continue. =20 + // If we got this far without any error codes, but the DataSize is 0 the= n the + // command response failed, so do not continue. // if (DataSize < 3) { Status =3D EFI_DEVICE_ERROR; --=20 2.37.1.windows.1