From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.12205.1676028227346163345
 for <devel@edk2.groups.io>;
 Fri, 10 Feb 2023 03:23:47 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iqT9LtMx;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1676028225;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=+irk13x0+l4IXoyAN5CzD7WWurVkv7BittkdrviSDAE=;
	b=iqT9LtMxwTrDePtLDle05e80AB7S2D8dpPCuxpKNRkSNP/kP+NYZY0enyaCNhkfrgEYqvw
	wmV4lWViAWgiMoIVznJU3abkU6ocTpUj/wP1N8TD8FMhjCLrspBtbQ/fii4PBUZ7WkoNYV
	kBlZYO5x8+9clTtnskDNkoUZD+3ZhgY=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-516-Eqrd5DabMd-Xi9SGP_Ceyw-1; Fri, 10 Feb 2023 06:23:44 -0500
X-MC-Unique: Eqrd5DabMd-Xi9SGP_Ceyw-1
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C620E1C05AF5;
	Fri, 10 Feb 2023 11:23:43 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.128])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 966E4492C3E;
	Fri, 10 Feb 2023 11:23:43 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 3167A1800082; Fri, 10 Feb 2023 12:23:42 +0100 (CET)
Date: Fri, 10 Feb 2023 12:23:42 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Zeng Star <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [PATCH v4 2/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data
Message-ID: <20230210112342.4ceic5w5j7p4oq5j@sirius.home.kraxel.org>
References: <20230210060519.11100-1-jiaxin.wu@intel.com>
 <20230210060519.11100-3-jiaxin.wu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230210060519.11100-3-jiaxin.wu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +#pragma pack(1)
> +typedef struct {
> +  ///
> +  /// CpuIndex tells which CPU range this specific HOB instance described.
> +  /// If CpuIndex is set to 0, it indicats the HOB describes the CPU from 0 to
> +  /// NumberOfCpus - 1. The HOB list may contains multiple this HOB instances.
> +  /// Each HOB instances describe the information for CPU from CpuIndex to
> +  /// CpuIndex + NumberOfCpus - 1. The instance order in the HOB list is random
> +  /// so consumer can not assume the CpuIndex of first instance is 0.
> +  ///
> +  UINT32    CpuIndex;
> +  ///
> +  /// Describes the Number of all max supported processors.
> +  ///
> +  UINT32    NumberOfProcessors;
> +  ///
> +  /// Pointer to SmBase address for each Processors.
> +  ///
> +  UINT64    SmBase[1];
> +} SMM_BASE_HOB_DATA;
> +#pragma pack()

No generic chunked hobs as suggested/discussed on v3 of this series?
Why not?

take care,
  Gerd