From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.12273.1676028411894685678
 for <devel@edk2.groups.io>;
 Fri, 10 Feb 2023 03:26:52 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZZuekUT0;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1676028410;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=m5eXDqlogT4n1ZWx0nPlkeshIukpj3PkOVvayBSquf0=;
	b=ZZuekUT07Sd6bTxwj6EErHjw120lutLU+YIiYoU0XSzia9UuxK54tVpkDTpedk8ugOnH7y
	WSWa7UiTBoP6U1HwMbca8Q4OsoZiqHcPIULcrPHxChchXfIxhXhG553ahmQiZ+YXtWLznH
	0awnGf6CV+kFj2euNRWR+Uk+/UfCbDk=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-22-7Yybqob-OZaYKmolkn044g-1; Fri, 10 Feb 2023 06:26:49 -0500
X-MC-Unique: 7Yybqob-OZaYKmolkn044g-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F6FB800050;
	Fri, 10 Feb 2023 11:26:49 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.128])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id E14C32026D76;
	Fri, 10 Feb 2023 11:26:48 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 01EE41800082; Fri, 10 Feb 2023 12:26:46 +0100 (CET)
Date: Fri, 10 Feb 2023 12:26:46 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Zeng Star <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info
Message-ID: <20230210112646.g6yz6put3mtarqtd@sirius.home.kraxel.org>
References: <20230210060519.11100-1-jiaxin.wu@intel.com>
 <20230210060519.11100-4-jiaxin.wu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230210060519.11100-4-jiaxin.wu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> Mainly changes as below:
> * Assume the biggest possibility of tile size is 8k.
> * Combine 2 SMIs (gcSmmInitTemplate & gcSmiHandlerTemplate) into one
> (gcSmiHandlerTemplate), the new SMI handler needs to run to 2 paths:
> one to SmmCpuFeaturesInitializeProcessor(), the other to SMM Core
> Entry Point.
> * Issue SMI IPI (All Excluding Self SMM IPI + BSP SMM IPI) for first
> SMI init before normal SMI sources happen.
> * Call SmmCpuFeaturesInitializeProcessor() in parallel.

Four changes in a single patch.  Please split them up.

thanks,
  Gerd