From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.14034.1676034134339788510 for ; Fri, 10 Feb 2023 05:02:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EqfpgpGl; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676034133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o7a0ixs5QnCuOvC1wiGPY4cab1P/kW/Nl8koDcsau9U=; b=EqfpgpGlVAuRGwEmxQ0wkIJvAWnq1M+zlFWwU+08s2vNvL5fX6BgIc3PA0wuOZM7qKL43D PP6NvhJgU19KnWIc5KkC2HTgFmOeMw98r7uXyVWPl7zazcRl30kJoVWtJrQ1MfmG+DczZW CZPKUxfd79HqZZmS+zZwdARcR3reJ5I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-471-BO1tXZawPQG7jImwWtMY6Q-1; Fri, 10 Feb 2023 08:02:10 -0500 X-MC-Unique: BO1tXZawPQG7jImwWtMY6Q-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF05A889057; Fri, 10 Feb 2023 13:02:09 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.128]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 827EA492B00; Fri, 10 Feb 2023 13:02:09 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 35A621800082; Fri, 10 Feb 2023 14:02:08 +0100 (CET) Date: Fri, 10 Feb 2023 14:02:08 +0100 From: "Gerd Hoffmann" To: "Ni, Ray" Cc: "devel@edk2.groups.io" , "Wu, Jiaxin" , "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Message-ID: <20230210130208.lbswcn3jnxs5inhb@sirius.home.kraxel.org> References: <20230210060519.11100-1-jiaxin.wu@intel.com> <20230210060519.11100-4-jiaxin.wu@intel.com> <20230210112646.g6yz6put3mtarqtd@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 10, 2023 at 12:37:23PM +0000, Ni, Ray wrote: > Gerd, > All the 4 are needed to make sure SMM still works. The new way (HOB present) of handling SMM init will surely require the whole patch series being applied. For the old way (HOB not present) of handling SMM init should be possible to split up into smaller pieces, which each step being individually testable. Specifically the SMI handler reorganization should be possible to split out, and I think the tiling changes too. These are preparing changes reorganizing the code, once they are in place the final patch adding the new code paths to handle the new SMM init should be relatively small. take care, Gerd