From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.11932.1676286829513594013 for ; Mon, 13 Feb 2023 03:13:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TSKWDef2; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BE7CBB81115; Mon, 13 Feb 2023 11:13:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CAE2C433EF; Mon, 13 Feb 2023 11:13:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676286826; bh=ehpe1rrXFS5u2TUZ1j8ot2w3L06fXB3CtaUUpNH3/Y4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TSKWDef2M3WCIx4Z/vlli0AxhSVuTOImnj85f+lzIg8P0SIRFXgpGi65LDO/vPkjs ahmtSazcDaomg48Ek36zqJQqZMNRx2XCJdzN2P2TJ6J5Leqj9ppuZyYnc/MtQB05wJ sFRbQhmF/Kmcjq4D681onSi/tP0krbGP7gz4BSYjUhk/+n+ZhKg/rLsyHLsAIYnEDr HmNzVp/gmbmtZJIVU/4YocYKJEeDQazwAC/CUpykooY/QChf4YiAWdURKnaArc9M1R VA1dHjT6/rUtHceNFtJ6SG6asApoKw3L7FIfkJUzD5qbdRZXs3b6egN/Q8wbOriL9W U7NxFWx7heteA== From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Rebecca Cran Subject: [PATCH edk2-platforms 1/2] Platform/BeagleBoard: Drop PeCoff protocol Date: Mon, 13 Feb 2023 12:13:38 +0100 Message-Id: <20230213111339.2239876-2-ardb@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213111339.2239876-1-ardb@kernel.org> References: <20230213111339.2239876-1-ardb@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable BeagleBoard is the only user of the so-called 'PE/COFF protocol', which just exposes the PE/COFF loader library API via a protocol, presumably to avoid duplicating this code in the PrePi SEC component as well as the DXE core. This is a rather questionable practice, and it would be better to drop this code so we can remove it from the EDK2 main repo as well. Signed-off-by: Ard Biesheuvel --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc = | 6 +-- Platform/BeagleBoard/BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLi= b.inf | 39 -------------------- 2 files changed, 2 insertions(+), 43 deletions(-) diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platf= orm/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc index d44f4771c622..0834770a6292 100644 --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc @@ -167,8 +167,7 @@ [LibraryClasses.common.DXE_CORE] DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf= =0D ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExt= ractGuidedSectionLib.inf=0D DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf=0D -# PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf=0D - PeCoffLib|Platform/BeagleBoard/BeagleBoardPkg/Library/DxeHobPeCoffLib/Dx= eHobPeCoffLib.inf=0D + PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf=0D =0D [LibraryClasses.common.DXE_DRIVER]=0D DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf=0D @@ -190,8 +189,7 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf=0D MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAll= ocationLib.inf=0D CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf= =0D -# PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf=0D - PeCoffLib|Platform/BeagleBoard/BeagleBoardPkg/Library/DxeHobPeCoffLib/Dx= eHobPeCoffLib.inf=0D + PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf=0D VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyL= ibRuntimeDxe.inf=0D =0D =0D diff --git a/Platform/BeagleBoard/BeagleBoardPkg/Library/DxeHobPeCoffLib/Dx= eHobPeCoffLib.inf b/Platform/BeagleBoard/BeagleBoardPkg/Library/DxeHobPeCof= fLib/DxeHobPeCoffLib.inf deleted file mode 100644 index 654bd8c874f3..000000000000 --- a/Platform/BeagleBoard/BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeC= offLib.inf +++ /dev/null @@ -1,39 +0,0 @@ -#/** @file=0D -# PE/COFF Loader Library implementation that wraps a protocol passed up f= rom=0D -# SEC/PEI via a HOB. This is done to save space.=0D -#=0D -# Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.
= =0D -# Portions copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
= =0D -# SPDX-License-Identifier: BSD-2-Clause-Patent=0D -#=0D -#=0D -#**/=0D -=0D -[Defines]=0D - INF_VERSION =3D 0x00010005=0D - BASE_NAME =3D DxeHobPeCoffLib=0D - FILE_GUID =3D 671C6FD7-99FB-4EE3-B640-4B1D463BC3B5= =0D - MODULE_TYPE =3D DXE_DRIVER=0D - VERSION_STRING =3D 1.0=0D - LIBRARY_CLASS =3D PeCoffLib=0D - CONSTRUCTOR =3D DxeHobPeCoffLibConstructor=0D -=0D -=0D -#=0D -# VALID_ARCHITECTURES =3D IA32 X64 EBC ARM=0D -#=0D -=0D -[Sources.common]=0D - DxeHobPeCoff.c=0D -=0D -=0D -[Packages]=0D - MdePkg/MdePkg.dec=0D - EmbeddedPkg/EmbeddedPkg.dec=0D -=0D -[LibraryClasses]=0D - DebugLib=0D - HobLib=0D -=0D -[Protocols]=0D - gPeCoffLoaderProtocolGuid=0D --=20 2.39.1