From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.13052.1676291654322484372
 for <devel@edk2.groups.io>;
 Mon, 13 Feb 2023 04:34:14 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QCNkVs/I;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1676291652;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=KNDlq5DhzDnptX89+D9ERAqfYERr+Dh++wGrQL54jF4=;
	b=QCNkVs/I6phvl415EApkD2YYjOddlQFHTff3r+wjNw8wood29EDNfOLdQwJCCC3C2ZCRvd
	3gp9irLCQPiMBAGjNyRCba/nVyfqQHiN+uMQLZ22YYkXuGFFUYk0ugh42BBe5eruZY2ex+
	b/zIu6XTvPmLjgDTidwCW24R8G5mkiU=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-298-XEqnojqMP32_hXRHBtcFcA-1; Mon, 13 Feb 2023 07:34:11 -0500
X-MC-Unique: XEqnojqMP32_hXRHBtcFcA-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 088413815F62;
	Mon, 13 Feb 2023 12:34:11 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.45])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id C6853C16022;
	Mon, 13 Feb 2023 12:34:10 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id DB3B61800082; Mon, 13 Feb 2023 13:34:05 +0100 (CET)
Date: Mon, 13 Feb 2023 13:34:05 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Zeng Star <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [PATCH v6 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace mIsBsp by mBspApicId
Message-ID: <20230213123405.cqc57thibrjpsjaz@sirius.home.kraxel.org>
References: <20230213084417.9232-1-jiaxin.wu@intel.com>
 <20230213084417.9232-3-jiaxin.wu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230213084417.9232-3-jiaxin.wu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 13, 2023 at 04:44:13PM +0800, Jiaxin Wu wrote:
> This patch is to replace mIsBsp by mBspApicId.

... and mIsBsp becomes the local variable IsBsp ...

>  EFIAPI
>  SmmInitHandler (
>    VOID
>    )
>  {
> -  UINT32  ApicId;
> -  UINTN   Index;
> +  UINT32   ApicId;
> +  UINTN    Index;
> +  BOOLEAN  IsBsp;

... which allows running SmmInitHandler in parallel.  Which is the
motivation for the change.  The commit message should explain that.

The code changes are fine.

take care,
  Gerd