From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Oliver Steffen <osteffen@redhat.com>,
Pawel Polawski <ppolawsk@redhat.com>
Subject: Re: [edk2-devel] [PATCH 0/4] CryptoPkg/BaseCryptLib: avoid certain openssl library calls
Date: Tue, 14 Feb 2023 11:13:44 +0100 [thread overview]
Message-ID: <20230214101344.radpmtyftk3wjli5@sirius.home.kraxel.org> (raw)
In-Reply-To: <MW4PR11MB58720310B6AC2E686C704DEE8CA29@MW4PR11MB5872.namprd11.prod.outlook.com>
On Tue, Feb 14, 2023 at 01:17:55AM +0000, Yao, Jiewen wrote:
> Good work, Gerd!
>
> Do you have any data on how many K can be saved?
Essentially we are down to a handfull of source files for SEC and PEI,
assuming both only need hash functions for tdx/tpm measurements.
https://github.com/kraxel/edk2/commit/58f323f68dfaeaf4b88a8658790f0b0a4b578642
SMM and DXE are still a significant increase in size and I don't see an
easy way around that. Switching to the crypto driver should mitigate
that somewhat. Don't have detailed numbers at hand.
take care,
Gerd
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd
> > Hoffmann
> > Sent: Tuesday, February 14, 2023 3:20 AM
> > To: devel@edk2.groups.io
> > Cc: Oliver Steffen <osteffen@redhat.com>; Pawel Polawski
> > <ppolawsk@redhat.com>; Gerd Hoffmann <kraxel@redhat.com>
> > Subject: [edk2-devel] [PATCH 0/4] CryptoPkg/BaseCryptLib: avoid certain
> > openssl library calls
> >
> > In preparation for the openssl 3.0 switch ...
> >
> > openssl 3.0 sneak preview (WIP still, does not yet pass CI) is at
> > https://github.com/kraxel/edk2/commits/openssl3
> >
> > Gerd Hoffmann (4):
> > CryptoPkg/BaseCryptLib: avoid using SHA1()
> > CryptoPkg/BaseCryptLib: avoid using SHA256()
> > CryptoPkg/BaseCryptLib: avoid using SHA384()
> > CryptoPkg/BaseCryptLib: avoid using SHA512()
> >
> > .../Library/BaseCryptLib/Hash/CryptSha1.c | 16 ++++++++--
> > .../Library/BaseCryptLib/Hash/CryptSha256.c | 16 ++++++++--
> > .../Library/BaseCryptLib/Hash/CryptSha512.c | 32 +++++++++++++++----
> > 3 files changed, 52 insertions(+), 12 deletions(-)
> >
> > --
> > 2.39.1
> >
> >
> >
> >
> >
>
--
next prev parent reply other threads:[~2023-02-14 10:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 19:19 [PATCH 0/4] CryptoPkg/BaseCryptLib: avoid certain openssl library calls Gerd Hoffmann
2023-02-13 19:19 ` [PATCH 1/4] CryptoPkg/BaseCryptLib: avoid using SHA1() Gerd Hoffmann
2023-02-13 22:14 ` [edk2-devel] " Michael D Kinney
2023-02-14 2:23 ` Yao, Jiewen
2023-02-13 19:19 ` [PATCH 2/4] CryptoPkg/BaseCryptLib: avoid using SHA256() Gerd Hoffmann
2023-02-13 19:19 ` [PATCH 3/4] CryptoPkg/BaseCryptLib: avoid using SHA384() Gerd Hoffmann
2023-02-13 19:19 ` [PATCH 4/4] CryptoPkg/BaseCryptLib: avoid using SHA512() Gerd Hoffmann
2023-02-14 1:17 ` [edk2-devel] [PATCH 0/4] CryptoPkg/BaseCryptLib: avoid certain openssl library calls Yao, Jiewen
2023-02-14 10:13 ` Gerd Hoffmann [this message]
2023-02-15 8:15 ` Yao, Jiewen
2023-03-07 6:54 ` Gerd Hoffmann
2023-03-07 7:59 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214101344.radpmtyftk3wjli5@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox