From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
Ray Ni <ray.ni@intel.com>, Zeng Star <star.zeng@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [PATCH v7 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace mIsBsp by mBspApicId check
Date: Tue, 14 Feb 2023 11:14:59 +0100 [thread overview]
Message-ID: <20230214101459.q4rhsgfdxbtdxzwf@sirius.home.kraxel.org> (raw)
In-Reply-To: <20230214083314.15092-3-jiaxin.wu@intel.com>
On Tue, Feb 14, 2023 at 04:33:10PM +0800, Jiaxin Wu wrote:
> This patch is to replace mIsBsp by mBspApicId check.
> mIsBsp becomes the local variable (IsBsp), then it can be
> checked dynamically in the function. Instead, we define the
> mBspApicId, which is to record the BSP ApicId used for
> compare in SmmInitHandler. With this change, SmmInitHandler
> can be run in parallel during SMM init.
>
> Note:
> This patch is the per-prepared work by refining the
> SmmInitHandler, then, we can do the next step to
> combine 2 SMIs (gcSmmInitTemplate & gcSmiHandlerTemplate)
> into one (gcSmiHandlerTemplate), the new SMI handler
> will call the SmmInitHandler in parallel to do the init.
Much better, thanks.
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2023-02-14 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 8:33 [PATCH v7 0/6] Simplify SMM Relocation Process Wu, Jiaxin
2023-02-14 8:33 ` [PATCH v7 1/6] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call Wu, Jiaxin
2023-02-14 10:19 ` Gerd Hoffmann
2023-02-14 8:33 ` [PATCH v7 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace mIsBsp by mBspApicId check Wu, Jiaxin
2023-02-14 10:14 ` Gerd Hoffmann [this message]
2023-02-14 8:33 ` [PATCH v7 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data Wu, Jiaxin
2023-02-14 10:19 ` Gerd Hoffmann
2023-02-15 8:41 ` Wu, Jiaxin
2023-02-14 8:33 ` [PATCH v7 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Wu, Jiaxin
2023-02-14 8:33 ` [PATCH v7 5/6] UefiCpuPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Wu, Jiaxin
2023-02-14 8:33 ` [PATCH v7 6/6] OvmfPkg/SmmCpuFeaturesLib: Check SmBase relocation supported or not Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214101459.q4rhsgfdxbtdxzwf@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox