From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.3268.1676369703524500006
 for <devel@edk2.groups.io>;
 Tue, 14 Feb 2023 02:15:03 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cH5sGUfo;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1676369702;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=peolOmyZXqhLjdIhrzzPWz0aE/wkaxK+t0yPuXHYMUM=;
	b=cH5sGUfoV8yYNpw2RQAmKBTAehIVqyEVU5j58Fb7GmQmYB51FyfaSz1Nu5sVkozYRcqQ0U
	hDAHNQt14hahVyCpmUPoutw7Pu7dE07a3K7ovMTSN+HLrsyfF1ntYWt1O88tmJPYPxcDIq
	jdOL75V/+ZvFOdK2Huqr1xwWt3qcQ9w=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-663-C1RmcZLXP8yi7Zi0UhkxvQ-1; Tue, 14 Feb 2023 05:15:01 -0500
X-MC-Unique: C1RmcZLXP8yi7Zi0UhkxvQ-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE396801779;
	Tue, 14 Feb 2023 10:15:00 +0000 (UTC)
Received: from sirius.home.kraxel.org (ovpn-195-41.brq.redhat.com [10.40.195.41])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 9A9984051E44;
	Tue, 14 Feb 2023 10:15:00 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 392411802381; Tue, 14 Feb 2023 11:14:59 +0100 (CET)
Date: Tue, 14 Feb 2023 11:14:59 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Zeng Star <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [PATCH v7 2/6] UefiCpuPkg/PiSmmCpuDxeSmm: Replace mIsBsp by mBspApicId check
Message-ID: <20230214101459.q4rhsgfdxbtdxzwf@sirius.home.kraxel.org>
References: <20230214083314.15092-1-jiaxin.wu@intel.com>
 <20230214083314.15092-3-jiaxin.wu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230214083314.15092-3-jiaxin.wu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 14, 2023 at 04:33:10PM +0800, Jiaxin Wu wrote:
> This patch is to replace mIsBsp by mBspApicId check.
> mIsBsp becomes the local variable (IsBsp), then it can be
> checked dynamically in the function. Instead, we define the
> mBspApicId, which is to record the BSP ApicId used for
> compare in SmmInitHandler. With this change, SmmInitHandler
> can be run in parallel during SMM init.
> 
> Note:
> This patch is the per-prepared work by refining the
> SmmInitHandler, then, we can do the next step to
> combine 2 SMIs (gcSmmInitTemplate & gcSmiHandlerTemplate)
> into one (gcSmiHandlerTemplate), the new SMI handler
> will call the SmmInitHandler in parallel to do the init.

Much better, thanks.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd