From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.3315.1676370004704487899
 for <devel@edk2.groups.io>;
 Tue, 14 Feb 2023 02:20:04 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ht8hrXgx;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1676370003;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=0lh6SaXGftp1d40Zd4O9zRJFsZu29sUrythGFkg5WV4=;
	b=Ht8hrXgx4eWuyZz2HryZX8JVS64BojifAngqlSAba7o3ru946hCElbmg/n7+chejtB03gG
	y/ZvLY+7rMJg8fKEI0qa4b3QsbaNlo/q7v3ZdJHF9U1eYf8aKc4NN9GS7Z+5w4F6sF56hA
	i12J775WrtOXEhT4I8ZhWjdhNrmis7U=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-241-WGjkDcWTMBilfeTiqRyZFw-1; Tue, 14 Feb 2023 05:19:58 -0500
X-MC-Unique: WGjkDcWTMBilfeTiqRyZFw-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 918DA85CCE0;
	Tue, 14 Feb 2023 10:19:57 +0000 (UTC)
Received: from sirius.home.kraxel.org (ovpn-195-41.brq.redhat.com [10.40.195.41])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 62EB040B40C9;
	Tue, 14 Feb 2023 10:19:57 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 0E08E1802381; Tue, 14 Feb 2023 11:19:56 +0100 (CET)
Date: Tue, 14 Feb 2023 11:19:56 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Zeng Star <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [PATCH v7 1/6] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call
Message-ID: <20230214101956.mcj6vb42gx57vswp@sirius.home.kraxel.org>
References: <20230214083314.15092-1-jiaxin.wu@intel.com>
 <20230214083314.15092-2-jiaxin.wu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230214083314.15092-2-jiaxin.wu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 14, 2023 at 04:33:09PM +0800, Jiaxin Wu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4338
> 
> No need call InitializeMpSyncData during normal boot SMI init,
> because mSmmMpSyncData is NULL at that time. mSmmMpSyncData is
> allocated in InitializeMpServiceData, which is invoked after
> normal boot SMI init (SmmRelocateBases).
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zeng Star <star.zeng@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
> Reviewed-by: Ray Ni <ray.ni@Intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>