From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.16462.1676471857537612245 for ; Wed, 15 Feb 2023 06:37:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cZQoLSgo; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676471856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S4pFHPxqAfpVVQl2qN60RVM/fOPf2mNGzj/fHvUjV7o=; b=cZQoLSgooePVPXKiZctjUwWkYjawv84soTcLv5WH72TfUGRslz5RRDPSvNdU5k3HLjEk9N JsjSdXpJ9w67YcOk35aZ3owfeYQDzca0ege2wwjXHMa7pwnUvLZ7atuevBUs1aFasQ9B0y cPPTBwCfktAyT7PLFsycG5JP1ljiy7I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-448-nfi9zMtiMFWI7LAs2PW_ig-1; Wed, 15 Feb 2023 09:37:34 -0500 X-MC-Unique: nfi9zMtiMFWI7LAs2PW_ig-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B64C88904B; Wed, 15 Feb 2023 14:37:34 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C3BC42026D4B; Wed, 15 Feb 2023 14:37:33 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1D3531800084; Wed, 15 Feb 2023 15:37:32 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Oliver Steffen , Sami Mujawar , Leif Lindholm , Ard Biesheuvel , Pawel Polawski , Gerd Hoffmann , Jeremy Boone Subject: [PATCH 1/1] ArmPkg/SemihostFs: replace SetMem with ZeroMem Date: Wed, 15 Feb 2023 15:37:32 +0100 Message-Id: <20230215143732.676580-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true SetMem arguments 2+3 are in the wrong order, resulting in the call having no effect because Length is zero. Fix this by using ZeroMem instead. Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4205 Reported-by: Jeremy Boone Signed-off-by: Gerd Hoffmann --- ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c index 39a30533ee57..9cc9ed7d3637 100644 --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c @@ -574,7 +574,7 @@ ExtendFile ( } Remaining = Size; - SetMem (WriteBuffer, 0, sizeof (WriteBuffer)); + ZeroMem (WriteBuffer, sizeof (WriteBuffer)); while (Remaining > 0) { WriteNb = MIN (Remaining, sizeof (WriteBuffer)); WriteSize = WriteNb; -- 2.39.1