public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Vishal Annapurve" <vannapurve@google.com>
To: devel@edk2.groups.io
Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn,
	 zhiguang.liu@intel.com, min.m.xu@intel.com,
	erdemaktas@google.com,  jiewen.yao@intel.com,
	Vishal Annapurve <vannapurve@google.com>
Subject: [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout
Date: Wed, 15 Feb 2023 19:50:42 +0000	[thread overview]
Message-ID: <20230215195042.1094110-1-vannapurve@google.com> (raw)

TDCALL_INFO should return num_vcpus as lower 4 bytes of r8 register according to
the tdx spec, so reorder num_vcpus and max_vcpus fields to match the spec.

Reference: Table 22.210 TDG.VP.INFO output operands
https://cdrdv2.intel.com/v1/dl/getContent/733568

Signed-off-by: Vishal Annapurve <vannapurve@google.com>
---
 MdePkg/Include/IndustryStandard/Tdx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/Tdx.h b/MdePkg/Include/IndustryStandard/Tdx.h
index 81df136184..a17be61353 100644
--- a/MdePkg/Include/IndustryStandard/Tdx.h
+++ b/MdePkg/Include/IndustryStandard/Tdx.h
@@ -111,8 +111,8 @@ typedef struct {
 typedef struct {
   UINT64    Gpaw;
   UINT64    Attributes;
-  UINT32    MaxVcpus;
   UINT32    NumVcpus;
+  UINT32    MaxVcpus;
   UINT64    Resv[3];
 } TDCALL_INFO_RETURN_DATA;
 
-- 
2.39.1.637.g21b0678d19-goog


             reply	other threads:[~2023-02-15 19:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 19:50 Vishal Annapurve [this message]
2023-02-16  0:10 ` [V1 PATCH 1/1] MdePkg: TDX: Correct TDCALL_INFO_RETURN_DATA layout Min Xu
2023-04-25 18:25   ` Vishal Annapurve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230215195042.1094110-1-vannapurve@google.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox