From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.31084.1676605885815720148 for ; Thu, 16 Feb 2023 19:51:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=gKSOr9HD; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31H2b2A9025227; Fri, 17 Feb 2023 03:51:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=WWLKQd8z67JuvBhOCbkl4FuQ182zEJhQOVTs7IAJVlo=; b=gKSOr9HDzdpZzO0wLaALxLs1laEOIaeTBJ7YgOqMnU5rS0tIUVgp5MhadNCBCPY8hhd2 HEU+mmwluTiJaFfyICF4iK0s7hBaz9g8KIFr1l//wjG4Q5ynyVCKnB4d57vSi94DY94w jBUByOU9WEjPs0kDZoT5CDYf2cp6B6LBTlt3bm7v4279C/Dcf/mxCPCJar/pD7uEcJh6 uejj8vjFjcUhY6YvwirP2mtEbXDgcqOWTrt3/QX9iMw8Q4Kymr1VRNdEuwi2H04O/LtF Ny4ij0Nhe1uVCRSKIe3s4CyXa5waKqtYjxxKry1wp0N8CjX0hI6aSCVyeekhSEf/HKEg lg== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ns0hkn3vv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 03:51:16 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31H3pGOi016390 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Feb 2023 03:51:16 GMT Received: from linbox.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 16 Feb 2023 19:51:15 -0800 From: "Rebecca Cran" To: , Andrew Fish , Leif Lindholm , Michael D Kinney , Bob Feng , Liming Gao , "Yuwei Chen" CC: Rebecca Cran Subject: [PATCH 3/3] BaseTools: Build against C++14 when building with clang Date: Thu, 16 Feb 2023 20:51:01 -0700 Message-ID: <20230217035101.880854-4-rebecca@quicinc.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230217035101.880854-1-rebecca@quicinc.com> References: <20230217035101.880854-1-rebecca@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: R0CZXMQN1ZhloiWubsTijVZn-EUjgGYV X-Proofpoint-GUID: R0CZXMQN1ZhloiWubsTijVZn-EUjgGYV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-16_18,2023-02-16_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 adultscore=0 mlxscore=0 priorityscore=1501 suspectscore=0 phishscore=0 mlxlogscore=782 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302170033 Content-Transfer-Encoding: 8bit Content-Type: text/plain clang 17 defaults to C++17, where the 'register' keyword is deprecated and the warning changed to an error. To avoid build errors, compile against C++14 by specifying '-std=c++14' in CXXFLAGS. Signed-off-by: Rebecca Cran --- BaseTools/Source/C/Makefiles/header.makefile | 2 +- BaseTools/Source/C/VfrCompile/GNUmakefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles/header.makefile index bcc2791998b0..1bf003523baf 100644 --- a/BaseTools/Source/C/Makefiles/header.makefile +++ b/BaseTools/Source/C/Makefiles/header.makefile @@ -106,7 +106,7 @@ endif endif ifneq ($(CLANG),) LDFLAGS = -CXXFLAGS = -Wno-deprecated-register -Wno-unused-result +CXXFLAGS = -Wno-deprecated-register -Wno-unused-result -std=c++14 else LDFLAGS = CXXFLAGS = -Wno-unused-result diff --git a/BaseTools/Source/C/VfrCompile/GNUmakefile b/BaseTools/Source/C/VfrCompile/GNUmakefile index fdd19f55f77e..7d851c38887c 100644 --- a/BaseTools/Source/C/VfrCompile/GNUmakefile +++ b/BaseTools/Source/C/VfrCompile/GNUmakefile @@ -23,7 +23,7 @@ else VFR_CPPFLAGS = -DPCCTS_USE_NAMESPACE_STD $(CPPFLAGS) endif # keep BUILD_OPTFLAGS last -VFR_CXXFLAGS = $(BUILD_OPTFLAGS) +VFR_CXXFLAGS = $(BUILD_OPTFLAGS) -std=c++14 # keep EXTRA_LDFLAGS last VFR_LFLAGS = $(EXTRA_LDFLAGS) -- 2.30.2