From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web10.2800.1676624212960387897 for ; Fri, 17 Feb 2023 00:56:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ejv8/uRY; spf=pass (domain: gmail.com, ip: 209.85.167.45, mailfrom: savvamtr@gmail.com) Received: by mail-lf1-f45.google.com with SMTP id g16so876655lfv.4 for ; Fri, 17 Feb 2023 00:56:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+vCR3NkoHV/p4hVIa3vOKMCjaFTaTZRaVFhIb/ISl4w=; b=ejv8/uRYByjNhvMvWtBU3/wWJ4HAaLJxeFa8ogZhb5AqysF+Se0xPVRb2iEIoKk1Ty QguNTNbpuRNho2dLMIojK9Vze4h2MlJ+tyOeHAhokxJ8bst8S0rw2PNVA0mRUfa+g4M+ Xbl1LRrx4TH/Nf2mSh+7T1mgGlsuPwu6oLaPZZjb/XZwrae5xDLBoQCDIe0kXFXwxa5l 5hw/dqTGCdvI+QChqbIK8GI4pY6iE1LD5LHxt6+54CDDaEOuK5iJIZrriyArXIS7hMyZ 1tit8sTy8ikJLezBUA26uvktH5smeY2t3RjuqFvNvsXwMc9XmSwT7DrxiNTSdD8RDaLe pMVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+vCR3NkoHV/p4hVIa3vOKMCjaFTaTZRaVFhIb/ISl4w=; b=4UKV41ShNcrKqv10528VZddGIDcv2udkQzeNbo8YrnXmarl95owWpJCNC09mJOZ/AH ofE/QBmHKEqyZ8ZBQnMosdNxpA8M0lnYtPyKLhODNwlywO8hO7y3MHEHjY0/j2Kmpel2 N/p7naKD3+ZyBATF6Em7re8ww/GrGCEE32iERQQ0I4pHSAzI9YDpQim09P3VLLGvmGcl p36s6IeFeGTeJC89MCx+QShAsMjZGOj4SdRIh1HYGoQUPOfjUlq8SvxYqQKo9OO3R8wH Fco0QEDSpyjxSZru5HpRatsz98gTANdeIjiCgvDGYDixlRd6XfiWiguXRYJ+fyNQ+yDr cixw== X-Gm-Message-State: AO0yUKU4Unp6k0l+w6CoqNs0rWbwvJQRg0CzvdedvUOhNJ6NZm6HQpzg YqPi2gTmvfBlL54xQOL4Z/b9qrRm5VXY5Jmg X-Google-Smtp-Source: AK7set/XOGqtDvhVnHeiqIPaV73Y521FnDrCqGptPapnvbi99mx+J0nK3xK3biXxXICwq3YBrVtjRQ== X-Received: by 2002:ac2:5982:0:b0:4b6:f30c:c7a9 with SMTP id w2-20020ac25982000000b004b6f30cc7a9mr3626641lfn.1.1676624210655; Fri, 17 Feb 2023 00:56:50 -0800 (PST) Return-Path: Received: from localhost.localdomain (gnv.theincredible.dev. [45.90.59.126]) by smtp.gmail.com with ESMTPSA id g1-20020a19ac01000000b004db45648d78sm616120lfc.13.2023.02.17.00.56.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 17 Feb 2023 00:56:50 -0800 (PST) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-platforms][PATCH v4 1/1] Ext4Pkg: Fixes double-free in Ext4ReadSymlink Date: Fri, 17 Feb 2023 14:56:47 +0600 Message-Id: <20230217085647.70781-1-savvamtr@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable The SymlinkTmp was deallocated unconditionally, so we shouldn't free it again on EFI_ERROR Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support") Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Symlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dxe/= Symlink.c index 1189a99ded2b..d80cb9fff92e 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c @@ -243,7 +243,6 @@ Ext4ReadSymlink ( Status=0D ));=0D FreePool (Symlink16Tmp);=0D - FreePool (SymlinkTmp);=0D return Status;=0D }=0D =0D --=20 2.39.1