* [edk2 1/1] BaseLib: don't log in InternalSwitchStack
@ 2023-02-18 4:29 Andrei Warkentin
2023-02-20 12:16 ` Sunil V L
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Warkentin @ 2023-02-18 4:29 UTC (permalink / raw)
To: devel
Cc: Andrei Warkentin, Sunil V L, Daniel Schaefer, Michael D Kinney,
Liming Gao, Zhiguang Liu
InternalSwitchStack may be called with a TPL high
enough for a DebugLib implementation to assert.
Other arch implementations don't log either.
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Daniel Schaefer <git@danielschaefer.me>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
---
MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c b/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
index cf646e498aba..b78424c16383 100644
--- a/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
+++ b/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
@@ -44,14 +44,6 @@ InternalSwitchStack (
{
BASE_LIBRARY_JUMP_BUFFER JumpBuffer;
- DEBUG ((
- DEBUG_INFO,
- "RISC-V InternalSwitchStack Entry:%x Context1:%x Context2:%x NewStack%x\n", \
- EntryPoint,
- Context1,
- Context2,
- NewStack
- ));
JumpBuffer.RA = (UINTN)EntryPoint;
JumpBuffer.SP = (UINTN)NewStack - sizeof (VOID *);
JumpBuffer.S0 = (UINT64)(UINTN)Context1;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [edk2 1/1] BaseLib: don't log in InternalSwitchStack
2023-02-18 4:29 [edk2 1/1] BaseLib: don't log in InternalSwitchStack Andrei Warkentin
@ 2023-02-20 12:16 ` Sunil V L
0 siblings, 0 replies; 2+ messages in thread
From: Sunil V L @ 2023-02-20 12:16 UTC (permalink / raw)
To: Andrei Warkentin
Cc: devel, Daniel Schaefer, Michael D Kinney, Liming Gao,
Zhiguang Liu
Thanks for these fixes!, Andrei.
Could you please use below format for the subject?
PackageName: ModuleName: summary of changes
Also, could you create single patch series with these patches?
Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
On Fri, Feb 17, 2023 at 10:29:21PM -0600, Andrei Warkentin wrote:
> InternalSwitchStack may be called with a TPL high
> enough for a DebugLib implementation to assert.
>
> Other arch implementations don't log either.
>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
> ---
> MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c b/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
> index cf646e498aba..b78424c16383 100644
> --- a/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
> +++ b/MdePkg/Library/BaseLib/RiscV64/InternalSwitchStack.c
> @@ -44,14 +44,6 @@ InternalSwitchStack (
> {
> BASE_LIBRARY_JUMP_BUFFER JumpBuffer;
>
> - DEBUG ((
> - DEBUG_INFO,
> - "RISC-V InternalSwitchStack Entry:%x Context1:%x Context2:%x NewStack%x\n", \
> - EntryPoint,
> - Context1,
> - Context2,
> - NewStack
> - ));
> JumpBuffer.RA = (UINTN)EntryPoint;
> JumpBuffer.SP = (UINTN)NewStack - sizeof (VOID *);
> JumpBuffer.S0 = (UINT64)(UINTN)Context1;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-20 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-18 4:29 [edk2 1/1] BaseLib: don't log in InternalSwitchStack Andrei Warkentin
2023-02-20 12:16 ` Sunil V L
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox