From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.31616.1676941794341321863 for ; Mon, 20 Feb 2023 17:09:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=e2gWqv7k; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31L0qqjA026591; Tue, 21 Feb 2023 01:09:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=DcA8U90HMwfpURQraMTyxUmRs8ojU6UjYv0wPJl3g7k=; b=e2gWqv7kp8krPFGegTZLyYVGyGNQSxZFUGUJrEhNS1voDioFV9VtIzjC9F+vs3AKaBwg cN5UcaYQZ8EGCBLKkp8AljP+x17hEiRMhYPCG7Ph/ZG8PrGQprZ1PZt3/9lZR2w9jq2n Bi81YWcjfbQ0MqoGgfSEmZHTSOjLF58SC6UvW0bH3rYsqKe7HVGIuVHUJqBNlWbKpCwn 0yJ+5M7472TDgHjACqmHeTGc3H4i3UObfUi+L1Pu1Z+AB/QXMVGnL+j3FAKRDu0gbUUb vSLBw08tN1/+uQRFbK5EivMCBR2+2KXXf6vnu3zE67pkodKGS/Oi7xcov4+KpFTDdk13 3A== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ntp98eg38-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 01:09:53 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31L19qrQ026713 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Feb 2023 01:09:52 GMT Received: from linbox.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 20 Feb 2023 17:09:51 -0800 From: "Rebecca Cran" To: , Ard Biesheuvel , "Leif Lindholm" , Radoslaw Biernacki CC: Rebecca Cran Subject: [PATCH edk2-platforms 2/2] Silicon/Qemu: Use the symbolic value for the SPCR table revision. Date: Mon, 20 Feb 2023 18:09:39 -0700 Message-ID: <20230221010939.1039066-3-rebecca@quicinc.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221010939.1039066-1-rebecca@quicinc.com> References: <20230221010939.1039066-1-rebecca@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 4hUqnIKnVJC99UtBit1vxl5HyBfBlSUo X-Proofpoint-ORIG-GUID: 4hUqnIKnVJC99UtBit1vxl5HyBfBlSUo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-20_19,2023-02-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 mlxscore=0 adultscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 impostorscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302210008 Content-Transfer-Encoding: 8bit Content-Type: text/plain From: Rebecca Cran The current SPCR table revision is 2. Instead of using a hard-coded value, use the symbolic constant EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION. Signed-off-by: Rebecca Cran --- Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc index 432097307f8a..435b7fe66778 100644 --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc @@ -17,7 +17,8 @@ STATIC EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr = { SBSAQEMU_ACPI_HEADER ( EFI_ACPI_6_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_SIGNATURE, EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE, - 2), /* New MS definition for PL011 support */ + /* New MS definition for PL011 support */ + EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION), EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_PL011_UART, { EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE }, { -- 2.30.2