From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.38194.1676969339617968308
 for <devel@edk2.groups.io>;
 Tue, 21 Feb 2023 00:48:59 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Uo+aIvP4;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1676969338;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=4RC2U7nIEZ16xEiVqacJPb+Hh2Oi2aGxrHeCsnB0IL8=;
	b=Uo+aIvP4rVjjKhSJOOEMu7TXPqlt8eWEcOrARFoTP18I78+WW3UOe9c0urgzEldynq26sQ
	nTl8WqyNmEolHLhirmMOLGurNUy/gQ2mygEVbnqprUD7bb3FM56/md1+duvQ+nAXNlOkdM
	T4WjfPpzRQ8bOuf29gZS/wywQUsAi2M=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-350-UkJD_vdUPSi1QfI4yndxYw-1; Tue, 21 Feb 2023 03:48:57 -0500
X-MC-Unique: UkJD_vdUPSi1QfI4yndxYw-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 98C5285A588;
	Tue, 21 Feb 2023 08:48:56 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.67])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 607D7492C3C;
	Tue, 21 Feb 2023 08:48:56 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id D41281800925; Tue, 21 Feb 2023 09:48:54 +0100 (CET)
Date: Tue, 21 Feb 2023 09:48:54 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process
Message-ID: <20230221084854.ckcwtl4tt3onq623@sirius.home.kraxel.org>
References: <17443983D6ED8995.20300@groups.io>
 <MN0PR11MB61587E015E7DD8004FB3E33FFEA49@MN0PR11MB6158.namprd11.prod.outlook.com>
 <MN6PR11MB8244A03F0D23FAAB19DF93F88CA49@MN6PR11MB8244.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <MN6PR11MB8244A03F0D23FAAB19DF93F88CA49@MN6PR11MB8244.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 20, 2023 at 01:14:33AM +0000, Ni, Ray wrote:
> I expect Gerd at least acknowledges all patches for UefiCpuPkg. Following three haven't got:
>  * [PATCH v9 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data
>  * [PATCH v9 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info
>  * [PATCH v9 5/6] UefiCpuPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

I still think it is worth cleaning cleaning up and remove both code and
comment for i486 and pentium processors from the last century.  That
should reduce confusion of the already complex code.  But if you insist
on not touching the existing code, so be it.

Series (for post-freeze merge):
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd