From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Dov Murik <dovmurik@linux.ibm.com>,
devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>, Min Xu <min.m.xu@intel.com>,
Michael Roth <michael.roth@amd.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Mario Smarduch <mario.smarduch@amd.com>,
Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
Subject: Re: [RESEND] [PATCH v2 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation
Date: Tue, 21 Feb 2023 10:38:20 +0100 [thread overview]
Message-ID: <20230221093820.amj4t2jhzrya7r5k@sirius.home.kraxel.org> (raw)
In-Reply-To: <67f06585-b9e6-a450-04fe-ad6b1105d3b6@amd.com>
On Mon, Feb 20, 2023 at 08:44:23AM -0600, Tom Lendacky wrote:
> On 2/20/23 02:49, Dov Murik wrote:
> > In order to allow the VMM (such as QEMU) to add a page with hashes of
> > kernel/initrd/cmdline for measured direct boot on SNP, this page must
> > not be part of the SNP metadata list reported to the VMM.
> >
> > Check if that page is defined; if it is, skip it in the metadata list.
> > In such case, VMM should fill the page with the hashes content, or
> > explicitly update it as a zero page (if kernel hashes are not used).
>
> Would it be better to define a new section type (similar to what I did in
> the SVSM PoC)? This way, it remains listed in the metadata and allows the
> VMM to detect it and decide how to handle it.
Explicitly describing things sounds better to me too.
take care,
Gerd
next prev parent reply other threads:[~2023-02-21 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 8:49 [RESEND] [PATCH v2 0/2] OvmfPkg: Enable measured direct boot on AMD SEV-SNP Dov Murik
2023-02-20 8:49 ` [RESEND] [PATCH v2 1/2] OvmfPkg/AmdSev: Reorder MEMFD pages to match the order in OvmfPkgX64.fdf Dov Murik
2023-02-20 8:49 ` [RESEND] [PATCH v2 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation Dov Murik
2023-02-20 14:44 ` Lendacky, Thomas
2023-02-21 9:38 ` Gerd Hoffmann [this message]
2023-02-23 14:58 ` Dov Murik
2023-02-23 15:04 ` Dov Murik
2023-02-27 18:50 ` Lendacky, Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221093820.amj4t2jhzrya7r5k@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox