From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.38828.1676972309276987132
 for <devel@edk2.groups.io>;
 Tue, 21 Feb 2023 01:38:29 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ejcGbEj9;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1676972307;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=KSOW0kRRqIfDpNPyJBLagyRUmn+ORzpg+qQJi0fE8g0=;
	b=ejcGbEj9i94cnG2d6OSUwq8t+0ytADT2lGSOonMXKItZ+oEvndmtUUFc/12tJgFA6y1iw4
	JyGZ7o3hL7CyA2ulRKstXwtRFcJomSNy6xmzh2Lx5O4v9D8BBcIcG2xFl0gq/3hyeE02/D
	8UUxPBj1RVgvXaX8UG/Zz/lKGdinR/k=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-544-POWOawvyMOK2GRPxCMN58g-1; Tue, 21 Feb 2023 04:38:22 -0500
X-MC-Unique: POWOawvyMOK2GRPxCMN58g-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFFC8380670A;
	Tue, 21 Feb 2023 09:38:21 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.67])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 6163118EC2;
	Tue, 21 Feb 2023 09:38:21 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 133301800639; Tue, 21 Feb 2023 10:38:20 +0100 (CET)
Date: Tue, 21 Feb 2023 10:38:20 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Dov Murik <dovmurik@linux.ibm.com>, devel@edk2.groups.io,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>, Min Xu <min.m.xu@intel.com>,
	Michael Roth <michael.roth@amd.com>,
	Ashish Kalra <ashish.kalra@amd.com>,
	Mario Smarduch <mario.smarduch@amd.com>,
	Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
Subject: Re: [RESEND] [PATCH v2 2/2] OvmfPkg/ResetVector: Exclude SEV launch secrets page from pre-validation
Message-ID: <20230221093820.amj4t2jhzrya7r5k@sirius.home.kraxel.org>
References: <20230220084942.1292756-1-dovmurik@linux.ibm.com>
 <20230220084942.1292756-3-dovmurik@linux.ibm.com>
 <67f06585-b9e6-a450-04fe-ad6b1105d3b6@amd.com>
MIME-Version: 1.0
In-Reply-To: <67f06585-b9e6-a450-04fe-ad6b1105d3b6@amd.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 20, 2023 at 08:44:23AM -0600, Tom Lendacky wrote:
> On 2/20/23 02:49, Dov Murik wrote:
> > In order to allow the VMM (such as QEMU) to add a page with hashes of
> > kernel/initrd/cmdline for measured direct boot on SNP, this page must
> > not be part of the SNP metadata list reported to the VMM.
> > 
> > Check if that page is defined; if it is, skip it in the metadata list.
> > In such case, VMM should fill the page with the hashes content, or
> > explicitly update it as a zero page (if kernel hashes are not used).
> 
> Would it be better to define a new section type (similar to what I did in
> the SVSM PoC)? This way, it remains listed in the metadata and allows the
> VMM to detect it and decide how to handle it.

Explicitly describing things sounds better to me too.

take care,
  Gerd