public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, Bob Feng <bob.c.feng@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Yuwei Chen <yuwei.chen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [PATCH 0/3] BaseTools: Fix doc block location and formatting; run uncrustify
Date: Fri, 24 Feb 2023 17:54:28 -0700	[thread overview]
Message-ID: <20230225005431.12173-1-rebecca@bsdio.com> (raw)

Fix the formatting and location of documentation blocks in Source/C/Common,
and replace the duplicate prototype of __PcdSet with __PcdGet. Those patches
will fail CI because it appears Uncrustify was never run on BaseTools?

Patch 3/3 reformats the files in Source/C/Common according to
Uncrustify.

Rebecca Cran (3):
  BaseTools: Source/C/Common: Fix doc block locations and convert to
    Doxygen
  BaseTools: Replace duplicate __PcdSet prototype with __PcdGet
  BaseTools: Run Uncrustify over files in Source/C/Common

 BaseTools/Source/C/Common/BinderFuncs.h             |   27 +-
 BaseTools/Source/C/Common/CommonLib.h               |  267 ++--
 BaseTools/Source/C/Common/Compress.h                |   45 +-
 BaseTools/Source/C/Common/Crc32.h                   |   36 +-
 BaseTools/Source/C/Common/Decompress.h              |  122 +-
 BaseTools/Source/C/Common/EfiUtilityMsgs.h          |   38 +-
 BaseTools/Source/C/Common/FirmwareVolumeBufferLib.h |  101 +-
 BaseTools/Source/C/Common/FvLib.h                   |   51 +-
 BaseTools/Source/C/Common/MemoryFile.h              |   76 +-
 BaseTools/Source/C/Common/MyAlloc.h                 |  196 +--
 BaseTools/Source/C/Common/OsPath.h                  |   92 +-
 BaseTools/Source/C/Common/ParseGuidedSectionTools.h |  101 +-
 BaseTools/Source/C/Common/ParseInf.h                |  228 ++--
 BaseTools/Source/C/Common/PcdValueCommon.h          |  196 +--
 BaseTools/Source/C/Common/PeCoffLib.h               |   66 +-
 BaseTools/Source/C/Common/SimpleFileParsing.h       |   24 +-
 BaseTools/Source/C/Common/StringFuncs.h             |  203 +--
 BaseTools/Source/C/Common/WinNtInclude.h            |   28 +-
 BaseTools/Source/C/Common/BasePeCoff.c              | 1068 +++++++--------
 BaseTools/Source/C/Common/BinderFuncs.c             |   31 +-
 BaseTools/Source/C/Common/CommonLib.c               |  914 ++++++-------
 BaseTools/Source/C/Common/Crc32.c                   |   38 +-
 BaseTools/Source/C/Common/Decompress.c              |  795 +++++------
 BaseTools/Source/C/Common/EfiCompress.c             | 1189 ++++++++--------
 BaseTools/Source/C/Common/EfiUtilityMsgs.c          |  663 ++++-----
 BaseTools/Source/C/Common/FirmwareVolumeBuffer.c    | 1426 ++++++++------------
 BaseTools/Source/C/Common/FvLib.c                   |  638 ++++-----
 BaseTools/Source/C/Common/MemoryFile.c              |  131 +-
 BaseTools/Source/C/Common/MyAlloc.c                 |  265 ++--
 BaseTools/Source/C/Common/OsPath.c                  |  180 +--
 BaseTools/Source/C/Common/ParseGuidedSectionTools.c |  142 +-
 BaseTools/Source/C/Common/ParseInf.c                |  401 +++---
 BaseTools/Source/C/Common/PcdValueCommon.c          |  618 ++++-----
 BaseTools/Source/C/Common/PeCoffLoaderEx.c          |  277 ++--
 BaseTools/Source/C/Common/SimpleFileParsing.c       |  737 +++++-----
 BaseTools/Source/C/Common/StringFuncs.c             |  310 ++---
 BaseTools/Source/C/Common/TianoCompress.c           | 1075 ++++++---------
 37 files changed, 5544 insertions(+), 7251 deletions(-)

-- 
2.37.1 (Apple Git-137.1)


             reply	other threads:[~2023-02-25  0:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-25  0:54 Rebecca Cran [this message]
2023-02-25  0:54 ` [PATCH 1/3] BaseTools: Source/C/Common: Fix doc block locations and convert to Doxygen Rebecca Cran
2023-02-25  0:54 ` [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with __PcdGet Rebecca Cran
2023-03-23 17:06   ` Rebecca Cran
2023-03-24  4:55   ` 回复: " gaoliming
2023-02-25  0:54 ` [PATCH 3/3] BaseTools: Run Uncrustify over files in Source/C/Common Rebecca Cran
     [not found] ` <1746EB2C4B4E3528.29542@groups.io>
2023-03-09 15:43   ` [edk2-devel] [PATCH 1/3] BaseTools: Source/C/Common: Fix doc block locations and convert to Doxygen Rebecca Cran
2023-03-10  2:57 ` 回复: [PATCH 0/3] BaseTools: Fix doc block location and formatting; run uncrustify gaoliming
2023-03-10 17:57   ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230225005431.12173-1-rebecca@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox