From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mx.groups.io with SMTP id smtpd.web10.35240.1677286484126259121 for ; Fri, 24 Feb 2023 16:54:44 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=cZN5n55U; spf=pass (domain: bsdio.com, ip: 64.147.123.19, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 74FBF3200927; Fri, 24 Feb 2023 19:54:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 24 Feb 2023 19:54:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1677286482; x=1677372882; bh=SD1wawvWE/m8ut2+WfDqQg2D6 WJZ8p9gmklJfwodz/M=; b=cZN5n55UeMdmg0rtcEppXcW7RgpFOF4jK5OjBAlaz 9op780Gi4bv5lFd9cIDaT7qM9KiZm7xAtpr7idUQyzRwKmtdK/vQOUVcM1TN1luV BNxnS1loXw1fje/UVQXHJ6Ji5bIrM5fYmwpXoR45kPBCB10jylUrAfEaIk4lADp0 YQ34tsAX9OC9rcf6+k3IAVil0/9k6Gh9z3LQjiNw5BeTetcCvYnVEMvJyfNQcZGf OrFuT3zDpsAy4JhBEg7CZZ/c/Q657Om20laA7Qu5ydUvkPAG2RDVEKdusehvDYSb A02rFXIimemGJGLGkSunkoG2QAZrINzJFQfoOhCfLleYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1677286482; x=1677372882; bh=SD1wawvWE/m8ut2+WfDqQg2D6WJZ8p9gmkl Jfwodz/M=; b=N4HtNFS3TxhKfHv/gKbgHyDznYwCtOVUcsJ/V0UvhLCoL01fVlF MfgHTb31B8CFu12ZV73c1PFKcoa/kmEppzkMPlgPZIhrvC4zP++WbPcQMzjDDWbg kxOgsgsxL4+rw8Qz5DXX38zHWucxJ6eVoNTdPWH3h+Xxdfz3rnkeT9w9l/dRfNUI 1MLq2G2taQAMnzFPB8V54b73BQE0KE5ldPWccZRYf6MYgoSN/qDjdyPVsv+ARJW2 xJ9jy02wi63vGeMQBHFwFg2382OYx5m/xvD4R987V1Ju4/Q39rpQ1RcAl6G4296T krcFnfS+W+j0nSpoPTj5plz3swQN/ayektg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekgedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomheptfgvsggvtggt rgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrthhtvg hrnhepuedvkedtleekueekgfejjeettefftdduiefffeehveefgfevueelgffhleelgfdv necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsg gvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Feb 2023 19:54:40 -0500 (EST) From: "Rebecca Cran" To: devel@edk2.groups.io, Bob Feng , Liming Gao , Yuwei Chen Cc: Rebecca Cran Subject: [PATCH 0/3] BaseTools: Fix doc block location and formatting; run uncrustify Date: Fri, 24 Feb 2023 17:54:28 -0700 Message-Id: <20230225005431.12173-1-rebecca@bsdio.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix the formatting and location of documentation blocks in Source/C/Common, and replace the duplicate prototype of __PcdSet with __PcdGet. Those patches will fail CI because it appears Uncrustify was never run on BaseTools? Patch 3/3 reformats the files in Source/C/Common according to Uncrustify. Rebecca Cran (3): BaseTools: Source/C/Common: Fix doc block locations and convert to Doxygen BaseTools: Replace duplicate __PcdSet prototype with __PcdGet BaseTools: Run Uncrustify over files in Source/C/Common BaseTools/Source/C/Common/BinderFuncs.h | 27 +- BaseTools/Source/C/Common/CommonLib.h | 267 ++-- BaseTools/Source/C/Common/Compress.h | 45 +- BaseTools/Source/C/Common/Crc32.h | 36 +- BaseTools/Source/C/Common/Decompress.h | 122 +- BaseTools/Source/C/Common/EfiUtilityMsgs.h | 38 +- BaseTools/Source/C/Common/FirmwareVolumeBufferLib.h | 101 +- BaseTools/Source/C/Common/FvLib.h | 51 +- BaseTools/Source/C/Common/MemoryFile.h | 76 +- BaseTools/Source/C/Common/MyAlloc.h | 196 +-- BaseTools/Source/C/Common/OsPath.h | 92 +- BaseTools/Source/C/Common/ParseGuidedSectionTools.h | 101 +- BaseTools/Source/C/Common/ParseInf.h | 228 ++-- BaseTools/Source/C/Common/PcdValueCommon.h | 196 +-- BaseTools/Source/C/Common/PeCoffLib.h | 66 +- BaseTools/Source/C/Common/SimpleFileParsing.h | 24 +- BaseTools/Source/C/Common/StringFuncs.h | 203 +-- BaseTools/Source/C/Common/WinNtInclude.h | 28 +- BaseTools/Source/C/Common/BasePeCoff.c | 1068 +++++++-------- BaseTools/Source/C/Common/BinderFuncs.c | 31 +- BaseTools/Source/C/Common/CommonLib.c | 914 ++++++------- BaseTools/Source/C/Common/Crc32.c | 38 +- BaseTools/Source/C/Common/Decompress.c | 795 +++++------ BaseTools/Source/C/Common/EfiCompress.c | 1189 ++++++++-------- BaseTools/Source/C/Common/EfiUtilityMsgs.c | 663 ++++----- BaseTools/Source/C/Common/FirmwareVolumeBuffer.c | 1426 ++++++++------------ BaseTools/Source/C/Common/FvLib.c | 638 ++++----- BaseTools/Source/C/Common/MemoryFile.c | 131 +- BaseTools/Source/C/Common/MyAlloc.c | 265 ++-- BaseTools/Source/C/Common/OsPath.c | 180 +-- BaseTools/Source/C/Common/ParseGuidedSectionTools.c | 142 +- BaseTools/Source/C/Common/ParseInf.c | 401 +++--- BaseTools/Source/C/Common/PcdValueCommon.c | 618 ++++----- BaseTools/Source/C/Common/PeCoffLoaderEx.c | 277 ++-- BaseTools/Source/C/Common/SimpleFileParsing.c | 737 +++++----- BaseTools/Source/C/Common/StringFuncs.c | 310 ++--- BaseTools/Source/C/Common/TianoCompress.c | 1075 ++++++--------- 37 files changed, 5544 insertions(+), 7251 deletions(-) -- 2.37.1 (Apple Git-137.1)