public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: devel@edk2.groups.io
Cc: Zhiguang Liu <zhiguang.liu@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib
Date: Mon, 27 Feb 2023 15:23:57 +0800	[thread overview]
Message-ID: <20230227072357.397-1-zhiguang.liu@intel.com> (raw)

V4:
This patch set has already gotten reviewed-by except OvmfPkg. Also V4 has a little code change for OvmfPkg.
So I only sent pathces about OvmfPkg (patch NO.1 and NO.4) to avoid disturbing other Package Maintainers.
Other patches can check the V3 version or check the PR link https://github.com/tianocore/edk2/pull/4066

V3:
Months ago, Pu Yu sent this patch serial and get reviewed-by, but some haven't been merged. Because the code base is changed, to merge the remaining patches into latest code base, two patches for OvmfPkg are modified.

Please OvmfPkg maintainers and reviewers help review patch #1 and #4.
Other patches keep unchanged and don't need review again.

V2:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394
Today lots of duplicated code call CPUID and calculates the address mask.
Adding an API named GetPhysicalAddressBits in UefiCpuLib can solve this problem, but at the same time cause MdeModulePkg depend on UefiCpuPkg which does not meet the design spec. So merge UefiCpuLib to CpuLib is a good way to sovle these problems. To minimize the impact,this change is carried out in four steps.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>

Yu Pu (8):
  MdePkg: Move API and implementation from UefiCpuLib to CpuLib
  IntelFsp2Pkg: Remove UefiCpuLib from module INFs.
  OvmfPkg: Remove UefiCpuLib from module INFs.
  PcAtChipsetPkg: Remove UefiCpuLib from module INFs.
  SourceLevelDebugPkg: Remove UefiCpuLib from module INFs.
  UefiCpuPkg: Remove UefiCpuLib from module INFs.
  UefiPayloadPkg: Remove UefiCpuLib from module INFs.
  UefiCpuLib: Remove UefiCpuLib.

Zhiguang Liu (1):
  OvmfPkg: Add CpuLib to module INFs that depend on UefiCpuLib.

 IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf     |  1 -
 IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf       |  1 -
 IntelFsp2Pkg/FspSecCore/SecMain.h             |  1 -
 IntelFsp2Pkg/IntelFsp2Pkg.dsc                 |  1 -
 IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc       |  1 -
 .../FspmWrapperPeim/FspmWrapperPeim.inf       |  1 -
 .../FspsWrapperPeim/FspsWrapperPeim.inf       |  1 -
 IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc   |  1 -
 MdePkg/Include/Library/CpuLib.h               | 48 ++++++++++++++
 MdePkg/Library/BaseCpuLib/BaseCpuLib.inf      |  6 ++
 .../BaseCpuLib}/Ia32/InitializeFpu.nasm       |  0
 .../BaseCpuLib}/X64/InitializeFpu.nasm        |  0
 .../Library/BaseCpuLib/X86BaseCpuLib.c        |  2 +-
 OvmfPkg/AmdSev/AmdSevX64.dsc                  |  1 -
 OvmfPkg/Bhyve/BhyveX64.dsc                    |  1 -
 OvmfPkg/CloudHv/CloudHvX64.dsc                |  1 -
 OvmfPkg/IntelTdx/IntelTdxX64.dsc              |  1 -
 OvmfPkg/IntelTdx/Sec/SecMain.c                |  2 +-
 OvmfPkg/IntelTdx/Sec/SecMain.inf              |  2 +-
 .../PeilessStartupLib/PeilessStartupLib.inf   |  2 +-
 OvmfPkg/Library/TdxMailboxLib/TdxMailbox.c    |  2 +-
 .../Library/TdxMailboxLib/TdxMailboxLib.inf   |  2 +-
 OvmfPkg/Microvm/MicrovmX64.dsc                |  1 -
 OvmfPkg/OvmfPkgIa32.dsc                       |  1 -
 OvmfPkg/OvmfPkgIa32X64.dsc                    |  1 -
 OvmfPkg/OvmfPkgX64.dsc                        |  1 -
 OvmfPkg/OvmfXen.dsc                           |  1 -
 OvmfPkg/Sec/SecMain.c                         |  1 -
 OvmfPkg/Sec/SecMain.inf                       |  1 -
 PcAtChipsetPkg/PcAtChipsetPkg.dsc             |  1 -
 SourceLevelDebugPkg/SourceLevelDebugPkg.dsc   |  1 -
 UefiCpuPkg/CpuDxe/CpuDxe.h                    |  1 -
 UefiCpuPkg/CpuDxe/CpuDxe.inf                  |  1 -
 UefiCpuPkg/Include/Library/UefiCpuLib.h       | 65 -------------------
 .../Library/BaseUefiCpuLib/BaseUefiCpuLib.inf | 41 ------------
 .../Library/BaseUefiCpuLib/BaseUefiCpuLib.uni | 16 -----
 .../Library/BaseXApicLib/BaseXApicLib.c       |  1 -
 .../Library/BaseXApicLib/BaseXApicLib.inf     |  1 -
 .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c   |  1 -
 .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf |  1 -
 UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf |  1 -
 UefiCpuPkg/Library/MpInitLib/MpLib.h          |  1 -
 UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf |  1 -
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h    |  1 -
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf  |  1 -
 .../PiSmmCpuDxeSmm/SmmProfileInternal.h       |  1 -
 UefiCpuPkg/SecCore/SecCore.inf                |  1 -
 UefiCpuPkg/SecCore/SecCoreNative.inf          |  1 -
 UefiCpuPkg/SecCore/SecMain.h                  |  1 -
 UefiCpuPkg/UefiCpuPkg.dec                     |  5 --
 UefiCpuPkg/UefiCpuPkg.dsc                     |  2 -
 .../UefiPayloadEntry/UefiPayloadEntry.h       |  1 -
 .../UefiPayloadEntry/UefiPayloadEntry.inf     |  1 -
 .../UniversalPayloadEntry.inf                 |  1 -
 UefiPayloadPkg/UefiPayloadPkg.dsc             |  1 -
 55 files changed, 60 insertions(+), 175 deletions(-)
 rename {UefiCpuPkg/Library/BaseUefiCpuLib => MdePkg/Library/BaseCpuLib}/Ia32/InitializeFpu.nasm (100%)
 rename {UefiCpuPkg/Library/BaseUefiCpuLib => MdePkg/Library/BaseCpuLib}/X64/InitializeFpu.nasm (100%)
 rename UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c => MdePkg/Library/BaseCpuLib/X86BaseCpuLib.c (93%)
 delete mode 100644 UefiCpuPkg/Include/Library/UefiCpuLib.h
 delete mode 100644 UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
 delete mode 100644 UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.uni

-- 
2.31.1.windows.1


             reply	other threads:[~2023-02-27  7:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27  7:23 Zhiguang Liu [this message]
2023-02-27  9:20 ` [edk2-devel] [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib Gerd Hoffmann
2023-02-28  1:50   ` Zhiguang Liu
2023-03-07  6:52     ` Gerd Hoffmann
     [not found]   ` <1747D9F1C3716F33.5262@groups.io>
2023-03-07  1:44     ` Zhiguang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230227072357.397-1-zhiguang.liu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox