From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.86251.1677489666830776155 for ; Mon, 27 Feb 2023 01:21:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hyd/6Kol; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677489665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TYDTYGLPoqAVmbX5yRt40wSi2lo3MzBR2Z7smkGvvlY=; b=hyd/6KolMlboWTQS6TpJyeLwsrGK4yFQk9/bI4+4kGwTTgGRJF6f5oSvMs9uwwIOumATUu NTsLDZXqBeRmrELPtpmKUofWf5aC2SbWiG9/wd9zKYpZdQNmRKKCoqT+naLv12UFXj3qZe nEECltz0Vkh57vf2WsLFeNVhWyVTTHY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-64Gd8epGOlirQowfusnZmA-1; Mon, 27 Feb 2023 04:21:02 -0500 X-MC-Unique: 64Gd8epGOlirQowfusnZmA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 816772A59558; Mon, 27 Feb 2023 09:21:01 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.45.224.150]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 331FBC15BAE; Mon, 27 Feb 2023 09:21:01 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 01B861800393; Mon, 27 Feb 2023 10:20:58 +0100 (CET) Date: Mon, 27 Feb 2023 10:20:58 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, zhiguang.liu@intel.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen Subject: Re: [edk2-devel] [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib Message-ID: <20230227092058.bfsueq3bhqhjwfwg@sirius.home.kraxel.org> References: <20230227072357.397-1-zhiguang.liu@intel.com> MIME-Version: 1.0 In-Reply-To: <20230227072357.397-1-zhiguang.liu@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 27, 2023 at 03:23:57PM +0800, Zhiguang Liu wrote: > V4: > This patch set has already gotten reviewed-by except OvmfPkg. Also V4 has a little code change for OvmfPkg. > So I only sent pathces about OvmfPkg (patch NO.1 and NO.4) to avoid disturbing other Package Maintainers. > Other patches can check the V3 version or check the PR link https://github.com/tianocore/edk2/pull/4066 It is perfectly fine to repost the whole series, especially when v3 was posted months ago. It's good to add any review tags to the patches though to make clear which are reviewed already and which are not. > UefiCpuPkg which does not meet the design spec. So merge UefiCpuLib to > CpuLib is a good way to sovle these problems. To minimize the > impact,this change is carried out in four steps. > rename {UefiCpuPkg/Library/BaseUefiCpuLib => MdePkg/Library/BaseCpuLib}/Ia32/InitializeFpu.nasm (100%) > rename {UefiCpuPkg/Library/BaseUefiCpuLib => MdePkg/Library/BaseCpuLib}/X64/InitializeFpu.nasm (100%) > rename UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.c => MdePkg/Library/BaseCpuLib/X86BaseCpuLib.c (93%) So in essence this series moves the code unmodified (other than some reaming due to the new location) and updates all references? take care, Gerd