public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: devel@edk2.groups.io
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Chasel Chiu <chasel.chiu@intel.com>
Subject: [PATCH v1] EmulatorPkg: Rename Variable
Date: Tue, 28 Feb 2023 20:55:23 -0800	[thread overview]
Message-ID: <20230301045524.1044-6-nathaniel.l.desimone@intel.com> (raw)
In-Reply-To: <20230301045524.1044-1-nathaniel.l.desimone@intel.com>

From: Nate DeSimone <nathaniel.l.desimone@intel.com>

Rename PeiCorePe32File to SecCorePe32File, because the variable
actually contains the SEC core... not PEI core.

Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 EmulatorPkg/Unix/Host/Host.c | 12 ++++++------
 EmulatorPkg/Unix/Host/Host.h |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/EmulatorPkg/Unix/Host/Host.c b/EmulatorPkg/Unix/Host/Host.c
index 1f29dd00a3..940e1953af 100644
--- a/EmulatorPkg/Unix/Host/Host.c
+++ b/EmulatorPkg/Unix/Host/Host.c
@@ -1,6 +1,6 @@
 /*++ @file
 
-Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.<BR>
 Portions copyright (c) 2008 - 2011, Apple Inc. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -535,7 +535,7 @@ Arguments:
   LargestRegion           - Memory to use for SEC.
   LargestRegionSize       - Size of Memory to use for PEI
   BootFirmwareVolumeBase  - Start of the Boot FV
-  PeiCorePe32File         - SEC PE32
+  SecCorePe32File         - SEC PE32
 
 Returns:
   Success means control is transferred and thus we should never return
@@ -546,13 +546,13 @@ SecLoadFromCore (
   IN  UINTN  LargestRegion,
   IN  UINTN  LargestRegionSize,
   IN  UINTN  BootFirmwareVolumeBase,
-  IN  VOID   *PeiCorePe32File
+  IN  VOID   *SecCorePe32File
   )
 {
   EFI_STATUS            Status;
   EFI_PHYSICAL_ADDRESS  TopOfMemory;
   VOID                  *TopOfStack;
-  EFI_PHYSICAL_ADDRESS  PeiCoreEntryPoint;
+  EFI_PHYSICAL_ADDRESS  SecCoreEntryPoint;
   EFI_SEC_PEI_HAND_OFF  *SecCoreData;
   UINTN                 PeiStackSize;
 
@@ -597,7 +597,7 @@ SecLoadFromCore (
   //
   // Find the SEC Core Entry Point
   //
-  Status = SecPeCoffGetEntryPoint (PeiCorePe32File, (VOID **)&PeiCoreEntryPoint);
+  Status = SecPeCoffGetEntryPoint (SecCorePe32File, (VOID **)&SecCoreEntryPoint);
   if (EFI_ERROR (Status)) {
     return;
   }
@@ -606,7 +606,7 @@ SecLoadFromCore (
   // Transfer control to the SEC Core
   //
   PeiSwitchStacks (
-    (SWITCH_STACK_ENTRY_POINT)(UINTN)PeiCoreEntryPoint,
+    (SWITCH_STACK_ENTRY_POINT)(UINTN)SecCoreEntryPoint,
     SecCoreData,
     (VOID *)gPpiList,
     TopOfStack
diff --git a/EmulatorPkg/Unix/Host/Host.h b/EmulatorPkg/Unix/Host/Host.h
index 0c81cdfc01..aecebc0143 100644
--- a/EmulatorPkg/Unix/Host/Host.h
+++ b/EmulatorPkg/Unix/Host/Host.h
@@ -1,6 +1,6 @@
 /*++ @file
 
-Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.<BR>
 Portions copyright (c) 2008 - 2011, Apple Inc. All rights reserved.<BR>
 
 SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -162,7 +162,7 @@ SecLoadFromCore (
   IN  UINTN  LargestRegion,
   IN  UINTN  LargestRegionSize,
   IN  UINTN  BootFirmwareVolumeBase,
-  IN  VOID   *PeiCoreFile
+  IN  VOID   *SecCoreFile
   );
 
 EFI_STATUS
-- 
2.30.2


  parent reply	other threads:[~2023-03-01  4:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  4:55 [PATCH v1] EmulatorPkg: Correct Comment Nate DeSimone
2023-03-01  4:55 ` [PATCH v1] EmulatorPkg: Delete EMU_IO_THUNK_PROTOCO_GUID Nate DeSimone
2023-03-01  4:55 ` [PATCH v1] EmulatorPkg: Fix misspelling Nate DeSimone
2023-03-01  5:11   ` Ni, Ray
2023-03-01  4:55 ` [PATCH v1] EmulatorPkg: Fix SecInterruptEnabled misspelling Nate DeSimone
2023-03-01  5:11   ` Ni, Ray
2023-03-01  4:55 ` [PATCH v1] EmulatorPkg: Remove Duplicate gEmuIoThunkProtocolGuid Nate DeSimone
2023-03-01  5:11   ` Ni, Ray
2023-03-01  4:55 ` Nate DeSimone [this message]
2023-03-01  5:11   ` [PATCH v1] EmulatorPkg: Rename Variable Ni, Ray
2023-03-01  4:55 ` [PATCH v1] MdeModulePkg: Fix misspelling Nate DeSimone
2023-04-04 12:58   ` 回复: [edk2-devel] " gaoliming
2023-03-01  5:10 ` [PATCH v1] EmulatorPkg: Correct Comment Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301045524.1044-6-nathaniel.l.desimone@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox