From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, andrei.warkentin@intel.com
Cc: Daniel Schaefer <git@danielschaefer.me>,
Sunil V L <sunilvl@ventanamicro.com>
Subject: Re: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi
Date: Wed, 1 Mar 2023 09:13:32 +0100 [thread overview]
Message-ID: <20230301081332.lzb5v7enjfillnfb@sirius.home.kraxel.org> (raw)
In-Reply-To: <20230301074358.26356-3-andrei.warkentin@intel.com>
Hi,
> + while ((Index < NumberOfBytes) && SerialPortPoll ()) {
> + Buffer[Index++] = (UINT8)mLastGetChar;
> + mLastGetChar = -1;
> + }
Why do you use a global variable to pass the character? SerialPortPoll
could just return it directly ...
take care,
Gerd
next prev parent reply other threads:[~2023-03-01 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 7:43 [edk2 0/2] RISC-V SBI-backed SerialLib Andrei Warkentin
2023-03-01 7:43 ` [edk2 1/2] MdePkg: BaseRiscVSbiLib: make more useful to consumers Andrei Warkentin
2023-03-01 7:43 ` [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi Andrei Warkentin
2023-03-01 8:13 ` Gerd Hoffmann [this message]
2023-03-01 8:50 ` [edk2-devel] " Andrei Warkentin
2023-03-01 9:07 ` Gerd Hoffmann
2023-03-01 16:55 ` Michael D Kinney
2023-03-01 17:26 ` Andrei Warkentin
2023-03-01 17:51 ` Michael D Kinney
2023-03-01 17:56 ` Andrei Warkentin
2023-03-02 10:34 ` Sunil V L
2023-03-02 13:32 ` Andrei Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301081332.lzb5v7enjfillnfb@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox