public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Warkentin, Andrei" <andrei.warkentin@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Daniel Schaefer <git@danielschaefer.me>,
	Sunil V L <sunilvl@ventanamicro.com>
Subject: Re: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi
Date: Wed, 1 Mar 2023 10:07:04 +0100	[thread overview]
Message-ID: <20230301090704.essvs54b2glrsjmd@sirius.home.kraxel.org> (raw)
In-Reply-To: <PH8PR11MB68563E2FBD725A773B6ABF6583AD9@PH8PR11MB6856.namprd11.prod.outlook.com>

On Wed, Mar 01, 2023 at 08:50:38AM +0000, Warkentin, Andrei wrote:
> The library caller could call Poll() first,

Ah, Poll is part of the library API, not just an internal helper.
Ok, makes sense then.

series:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd


  reply	other threads:[~2023-03-01  9:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  7:43 [edk2 0/2] RISC-V SBI-backed SerialLib Andrei Warkentin
2023-03-01  7:43 ` [edk2 1/2] MdePkg: BaseRiscVSbiLib: make more useful to consumers Andrei Warkentin
2023-03-01  7:43 ` [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi Andrei Warkentin
2023-03-01  8:13   ` [edk2-devel] " Gerd Hoffmann
2023-03-01  8:50     ` Andrei Warkentin
2023-03-01  9:07       ` Gerd Hoffmann [this message]
2023-03-01 16:55         ` Michael D Kinney
2023-03-01 17:26           ` Andrei Warkentin
2023-03-01 17:51             ` Michael D Kinney
2023-03-01 17:56               ` Andrei Warkentin
2023-03-02 10:34                 ` Sunil V L
2023-03-02 13:32                   ` Andrei Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301090704.essvs54b2glrsjmd@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox