[PATCH 0/2] Modify defination for MpWakeupStructure

[PATCH 0/2] Modify defination for MpWakeupStructure

[duntan]

Modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination.
Add define for Multiprocessor Wakeup Structure Version.

Dun Tan (2):
  MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure
  MdePkg: add define for Multiprocessor Wakeup Structure Version

 MdePkg/Include/IndustryStandard/Acpi64.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

-- 
2.31.1.windows.1

[PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure

[duntan]

modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination
in Acpi64.h.

Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 MdePkg/Include/IndustryStandard/Acpi64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
index 575ca0430c..16c2faaaf2 100644
--- a/MdePkg/Include/IndustryStandard/Acpi64.h
+++ b/MdePkg/Include/IndustryStandard/Acpi64.h
@@ -607,7 +607,7 @@ typedef struct {
 typedef struct {
   UINT16    Command;
   UINT16    Reserved;
-  UINT32    AcpiId;
+  UINT32    ApicId;
   UINT64    WakeupVector;
   UINT8     ReservedForOs[2032];
   UINT8     ReservedForFirmware[2048];
-- 
2.31.1.windows.1

[PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version

[duntan]

Add define for Multiprocessor Wakeup Structure Version. The version
for MpWakeupStructure in Spec6.4 is 0.

Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
index 16c2faaaf2..4920939bdc 100644
--- a/MdePkg/Include/IndustryStandard/Acpi64.h
+++ b/MdePkg/Include/IndustryStandard/Acpi64.h
@@ -601,6 +601,11 @@ typedef struct {
   UINT64    MailBoxAddress;
 } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE;
 
+///
+/// Multiprocessor Wakeup Structure Version (as defined in ACPI 6.4 spec.)
+///
+#define EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE_REVISION  0x0
+
 ///
 /// Multiprocessor Wakeup Mailbox Structure
 ///
-- 
2.31.1.windows.1

Re: [edk2-devel] [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure

[Zhiguang Liu]

Thanks for the fix.
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of duntan
> Sent: Friday, March 3, 2023 3:26 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to
> 'ApicId' in MpWakeupStructure
> 
> modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination in
> Acpi64.h.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi64.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 575ca0430c..16c2faaaf2 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -607,7 +607,7 @@ typedef struct {
>  typedef struct {
>    UINT16    Command;
>    UINT16    Reserved;
> -  UINT32    AcpiId;
> +  UINT32    ApicId;
>    UINT64    WakeupVector;
>    UINT8     ReservedForOs[2032];
>    UINT8     ReservedForFirmware[2048];
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 

Re: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version

[Zhiguang Liu]

Hi Dun,
Do you mean the mailbox version?
Here is from spec
	MailBox Version | Version of the mailbox. 0 for this version of the spec.
If so, I suggest the macro name should be EFI_ACPI_6_4_MULTIPROCESSOR _WAKEUP_MAILBOX _STRUCTURE_VERSION 

Thanks
Zhiguang

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, March 3, 2023 3:26 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup
> Structure Version
> 
> Add define for Multiprocessor Wakeup Structure Version. The version for
> MpWakeupStructure in Spec6.4 is 0.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 16c2faaaf2..4920939bdc 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -601,6 +601,11 @@ typedef struct {
>    UINT64    MailBoxAddress;
>  } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE;
> 
> +///
> +/// Multiprocessor Wakeup Structure Version (as defined in ACPI 6.4
> +spec.) /// #define
> +EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE_REVISION  0x0
> +
>  ///
>  /// Multiprocessor Wakeup Mailbox Structure  ///
> --
> 2.31.1.windows.1

Re: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version

[duntan]

Thanks for the comments Zhiguang. Will update the macro name in V2 patch.

Thanks,
Dun

-----Original Message-----
From: Liu, Zhiguang <zhiguang.liu@intel.com> 
Sent: Thursday, March 9, 2023 10:24 AM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>
Subject: RE: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version

Hi Dun,
Do you mean the mailbox version?
Here is from spec
	MailBox Version | Version of the mailbox. 0 for this version of the spec.
If so, I suggest the macro name should be EFI_ACPI_6_4_MULTIPROCESSOR _WAKEUP_MAILBOX _STRUCTURE_VERSION 

Thanks
Zhiguang

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, March 3, 2023 3:26 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming 
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; 
> Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup 
> Structure Version
> 
> Add define for Multiprocessor Wakeup Structure Version. The version 
> for MpWakeupStructure in Spec6.4 is 0.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 16c2faaaf2..4920939bdc 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -601,6 +601,11 @@ typedef struct {
>    UINT64    MailBoxAddress;
>  } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE;
> 
> +///
> +/// Multiprocessor Wakeup Structure Version (as defined in ACPI 6.4
> +spec.) /// #define
> +EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE_REVISION  0x0
> +
>  ///
>  /// Multiprocessor Wakeup Mailbox Structure  ///
> --
> 2.31.1.windows.1