* [PATCH 0/2] Modify defination for MpWakeupStructure @ 2023-03-03 7:26 duntan 2023-03-03 7:26 ` [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure duntan 2023-03-03 7:26 ` [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version duntan 0 siblings, 2 replies; 6+ messages in thread From: duntan @ 2023-03-03 7:26 UTC (permalink / raw) To: devel Modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination. Add define for Multiprocessor Wakeup Structure Version. Dun Tan (2): MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure MdePkg: add define for Multiprocessor Wakeup Structure Version MdePkg/Include/IndustryStandard/Acpi64.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure 2023-03-03 7:26 [PATCH 0/2] Modify defination for MpWakeupStructure duntan @ 2023-03-03 7:26 ` duntan 2023-03-09 2:06 ` [edk2-devel] " Zhiguang Liu 2023-03-03 7:26 ` [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version duntan 1 sibling, 1 reply; 6+ messages in thread From: duntan @ 2023-03-03 7:26 UTC (permalink / raw) To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination in Acpi64.h. Signed-off-by: Dun Tan <dun.tan@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Ray Ni <ray.ni@intel.com> --- MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index 575ca0430c..16c2faaaf2 100644 --- a/MdePkg/Include/IndustryStandard/Acpi64.h +++ b/MdePkg/Include/IndustryStandard/Acpi64.h @@ -607,7 +607,7 @@ typedef struct { typedef struct { UINT16 Command; UINT16 Reserved; - UINT32 AcpiId; + UINT32 ApicId; UINT64 WakeupVector; UINT8 ReservedForOs[2032]; UINT8 ReservedForFirmware[2048]; -- 2.31.1.windows.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure 2023-03-03 7:26 ` [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure duntan @ 2023-03-09 2:06 ` Zhiguang Liu 0 siblings, 0 replies; 6+ messages in thread From: Zhiguang Liu @ 2023-03-09 2:06 UTC (permalink / raw) To: devel@edk2.groups.io, Tan, Dun; +Cc: Kinney, Michael D, Gao, Liming, Ni, Ray Thanks for the fix. Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of duntan > Sent: Friday, March 3, 2023 3:26 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, > Ray <ray.ni@intel.com> > Subject: [edk2-devel] [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to > 'ApicId' in MpWakeupStructure > > modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination in > Acpi64.h. > > Signed-off-by: Dun Tan <dun.tan@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > --- > MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > b/MdePkg/Include/IndustryStandard/Acpi64.h > index 575ca0430c..16c2faaaf2 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -607,7 +607,7 @@ typedef struct { > typedef struct { > UINT16 Command; > UINT16 Reserved; > - UINT32 AcpiId; > + UINT32 ApicId; > UINT64 WakeupVector; > UINT8 ReservedForOs[2032]; > UINT8 ReservedForFirmware[2048]; > -- > 2.31.1.windows.1 > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version 2023-03-03 7:26 [PATCH 0/2] Modify defination for MpWakeupStructure duntan 2023-03-03 7:26 ` [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure duntan @ 2023-03-03 7:26 ` duntan 2023-03-09 2:23 ` Zhiguang Liu 1 sibling, 1 reply; 6+ messages in thread From: duntan @ 2023-03-03 7:26 UTC (permalink / raw) To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni Add define for Multiprocessor Wakeup Structure Version. The version for MpWakeupStructure in Spec6.4 is 0. Signed-off-by: Dun Tan <dun.tan@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Ray Ni <ray.ni@intel.com> --- MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h index 16c2faaaf2..4920939bdc 100644 --- a/MdePkg/Include/IndustryStandard/Acpi64.h +++ b/MdePkg/Include/IndustryStandard/Acpi64.h @@ -601,6 +601,11 @@ typedef struct { UINT64 MailBoxAddress; } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE; +/// +/// Multiprocessor Wakeup Structure Version (as defined in ACPI 6.4 spec.) +/// +#define EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE_REVISION 0x0 + /// /// Multiprocessor Wakeup Mailbox Structure /// -- 2.31.1.windows.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version 2023-03-03 7:26 ` [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version duntan @ 2023-03-09 2:23 ` Zhiguang Liu 2023-03-09 2:39 ` duntan 0 siblings, 1 reply; 6+ messages in thread From: Zhiguang Liu @ 2023-03-09 2:23 UTC (permalink / raw) To: Tan, Dun, devel@edk2.groups.io; +Cc: Kinney, Michael D, Gao, Liming, Ni, Ray Hi Dun, Do you mean the mailbox version? Here is from spec MailBox Version | Version of the mailbox. 0 for this version of the spec. If so, I suggest the macro name should be EFI_ACPI_6_4_MULTIPROCESSOR _WAKEUP_MAILBOX _STRUCTURE_VERSION Thanks Zhiguang > -----Original Message----- > From: Tan, Dun <dun.tan@intel.com> > Sent: Friday, March 3, 2023 3:26 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, > Ray <ray.ni@intel.com> > Subject: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup > Structure Version > > Add define for Multiprocessor Wakeup Structure Version. The version for > MpWakeupStructure in Spec6.4 is 0. > > Signed-off-by: Dun Tan <dun.tan@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > --- > MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > b/MdePkg/Include/IndustryStandard/Acpi64.h > index 16c2faaaf2..4920939bdc 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -601,6 +601,11 @@ typedef struct { > UINT64 MailBoxAddress; > } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE; > > +/// > +/// Multiprocessor Wakeup Structure Version (as defined in ACPI 6.4 > +spec.) /// #define > +EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE_REVISION 0x0 > + > /// > /// Multiprocessor Wakeup Mailbox Structure /// > -- > 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version 2023-03-09 2:23 ` Zhiguang Liu @ 2023-03-09 2:39 ` duntan 0 siblings, 0 replies; 6+ messages in thread From: duntan @ 2023-03-09 2:39 UTC (permalink / raw) To: Liu, Zhiguang, devel@edk2.groups.io Cc: Kinney, Michael D, Gao, Liming, Ni, Ray Thanks for the comments Zhiguang. Will update the macro name in V2 patch. Thanks, Dun -----Original Message----- From: Liu, Zhiguang <zhiguang.liu@intel.com> Sent: Thursday, March 9, 2023 10:24 AM To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com> Subject: RE: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version Hi Dun, Do you mean the mailbox version? Here is from spec MailBox Version | Version of the mailbox. 0 for this version of the spec. If so, I suggest the macro name should be EFI_ACPI_6_4_MULTIPROCESSOR _WAKEUP_MAILBOX _STRUCTURE_VERSION Thanks Zhiguang > -----Original Message----- > From: Tan, Dun <dun.tan@intel.com> > Sent: Friday, March 3, 2023 3:26 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; > Ni, Ray <ray.ni@intel.com> > Subject: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup > Structure Version > > Add define for Multiprocessor Wakeup Structure Version. The version > for MpWakeupStructure in Spec6.4 is 0. > > Signed-off-by: Dun Tan <dun.tan@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > --- > MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > b/MdePkg/Include/IndustryStandard/Acpi64.h > index 16c2faaaf2..4920939bdc 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -601,6 +601,11 @@ typedef struct { > UINT64 MailBoxAddress; > } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE; > > +/// > +/// Multiprocessor Wakeup Structure Version (as defined in ACPI 6.4 > +spec.) /// #define > +EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE_REVISION 0x0 > + > /// > /// Multiprocessor Wakeup Mailbox Structure /// > -- > 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-09 2:39 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-03-03 7:26 [PATCH 0/2] Modify defination for MpWakeupStructure duntan 2023-03-03 7:26 ` [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure duntan 2023-03-09 2:06 ` [edk2-devel] " Zhiguang Liu 2023-03-03 7:26 ` [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version duntan 2023-03-09 2:23 ` Zhiguang Liu 2023-03-09 2:39 ` duntan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox