* [PATCH] Platform/Loongson: Allow building with stack protector support
@ 2023-03-05 4:40 WANG Xuerui
2023-03-07 1:44 ` [edk2-devel] " Chao Li
2023-03-08 3:17 ` xianglai
0 siblings, 2 replies; 4+ messages in thread
From: WANG Xuerui @ 2023-03-05 4:40 UTC (permalink / raw)
To: devel
Cc: WANG Xuerui, Bibo Mao, Xianglai li, Chao Li, Leif Lindholm,
Michael D Kinney
Some toolchains have stack protection enabled by default, so without the
appropriate library included the build will fail with missing symbols
during link.
Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: WANG Xuerui <git@xen0n.name>
---
Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
index d1162519cd..465e9229a2 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
+++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
@@ -95,6 +95,9 @@
TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
!endif
+ # For stack protector support
+ NULL | MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
+
BaseLib | MdePkg/Library/BaseLib/BaseLib.inf
SafeIntLib | MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
TimeBaseLib | EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support
2023-03-05 4:40 [PATCH] Platform/Loongson: Allow building with stack protector support WANG Xuerui
@ 2023-03-07 1:44 ` Chao Li
2023-03-08 3:17 ` xianglai
1 sibling, 0 replies; 4+ messages in thread
From: Chao Li @ 2023-03-07 1:44 UTC (permalink / raw)
To: devel, git; +Cc: Bibo Mao, Xianglai li, Leif Lindholm, Michael D Kinney
[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]
Reviewed-by: Chao Li <lichao@loongson.cn>
Thanks,
Chao
在 2023/3/5 12:40, WANG Xuerui 写道:
> Some toolchains have stack protection enabled by default, so without the
> appropriate library included the build will fail with missing symbols
> during link.
>
> Cc: Bibo Mao<maobibo@loongson.cn>
> Cc: Xianglai li<lixianglai@loongson.cn>
> Cc: Chao Li<lichao@loongson.cn>
> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
> Cc: Michael D Kinney<michael.d.kinney@intel.com>
> Signed-off-by: WANG Xuerui<git@xen0n.name>
> ---
> Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> index d1162519cd..465e9229a2 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> @@ -95,6 +95,9 @@
> TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> !endif
>
> + # For stack protector support
> + NULL | MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +
> BaseLib | MdePkg/Library/BaseLib/BaseLib.inf
> SafeIntLib | MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> TimeBaseLib | EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
[-- Attachment #2: Type: text/html, Size: 2498 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support
2023-03-05 4:40 [PATCH] Platform/Loongson: Allow building with stack protector support WANG Xuerui
2023-03-07 1:44 ` [edk2-devel] " Chao Li
@ 2023-03-08 3:17 ` xianglai
2023-03-20 8:07 ` Chao Li
1 sibling, 1 reply; 4+ messages in thread
From: xianglai @ 2023-03-08 3:17 UTC (permalink / raw)
To: devel, git; +Cc: Bibo Mao, Chao Li, Leif Lindholm, Michael D Kinney
[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]
Reviewed-by: Xianglai Li <lixianglai@loongson.cn>
On 2023/3/5 下午12:40, WANG Xuerui wrote:
> Some toolchains have stack protection enabled by default, so without the
> appropriate library included the build will fail with missing symbols
> during link.
>
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Xianglai li <lixianglai@loongson.cn>
> Cc: Chao Li <lichao@loongson.cn>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: WANG Xuerui <git@xen0n.name>
> ---
> Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> index d1162519cd..465e9229a2 100644
> --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
> @@ -95,6 +95,9 @@
> TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> !endif
>
> + # For stack protector support
> + NULL | MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> +
> BaseLib | MdePkg/Library/BaseLib/BaseLib.inf
> SafeIntLib | MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> TimeBaseLib | EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
[-- Attachment #2: Type: text/html, Size: 2213 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support
2023-03-08 3:17 ` xianglai
@ 2023-03-20 8:07 ` Chao Li
0 siblings, 0 replies; 4+ messages in thread
From: Chao Li @ 2023-03-20 8:07 UTC (permalink / raw)
To: devel, lixianglai, git; +Cc: Bibo Mao, Leif Lindholm, Michael D Kinney
[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]
Hi Xuerui,
I and Xianglai have reviewed this change a few days ago, you can create
a PR in the edk2-platforms repo.
Thanks,
Chao
在 2023/3/8 11:17, xianglai 写道:
>
> Reviewed-by: Xianglai Li <lixianglai@loongson.cn>
>
> On 2023/3/5 下午12:40, WANG Xuerui wrote:
>> Some toolchains have stack protection enabled by default, so without the
>> appropriate library included the build will fail with missing symbols
>> during link.
>>
>> Cc: Bibo Mao<maobibo@loongson.cn>
>> Cc: Xianglai li<lixianglai@loongson.cn>
>> Cc: Chao Li<lichao@loongson.cn>
>> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
>> Cc: Michael D Kinney<michael.d.kinney@intel.com>
>> Signed-off-by: WANG Xuerui<git@xen0n.name>
>> ---
>> Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
>> index d1162519cd..465e9229a2 100644
>> --- a/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
>> +++ b/Platform/Loongson/LoongArchQemuPkg/Loongson.dsc
>> @@ -95,6 +95,9 @@
>> TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>> !endif
>>
>> + # For stack protector support
>> + NULL | MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>> +
>> BaseLib | MdePkg/Library/BaseLib/BaseLib.inf
>> SafeIntLib | MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
>> TimeBaseLib | EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>
[-- Attachment #2: Type: text/html, Size: 3186 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-20 8:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-05 4:40 [PATCH] Platform/Loongson: Allow building with stack protector support WANG Xuerui
2023-03-07 1:44 ` [edk2-devel] " Chao Li
2023-03-08 3:17 ` xianglai
2023-03-20 8:07 ` Chao Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox