From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.28133.1678086842957407009 for ; Sun, 05 Mar 2023 23:14:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ErQFApGD; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678086841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vQ2zmj1qIaiyizL6YNdWVQ6s/VRsxqW/bT1nPe84FDg=; b=ErQFApGDWEmlJSiQDsY9eH1XiD/978LL32MnMeyGeCRT1nl4jFqyMoHd+5fW2J5FK9fF0Q 5Y8+4lic/zwP/gcpGPoOpBJjsdyJ76g8A4FADdv02t5d2B1wOeoFSbYuQ/AsScc8pbFMB+ rnrn+FQlcGonBSN45eMe3CFNeqQ8v38= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-80-S_HF5yisP3OwMQWKW-oglQ-1; Mon, 06 Mar 2023 02:13:58 -0500 X-MC-Unique: S_HF5yisP3OwMQWKW-oglQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 29C7F101A521; Mon, 6 Mar 2023 07:13:58 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00621492C1B; Mon, 6 Mar 2023 07:13:57 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9592E1800613; Mon, 6 Mar 2023 08:13:53 +0100 (CET) Date: Mon, 6 Mar 2023 08:13:53 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, dun.tan@intel.com Cc: Eric Dong , Ray Ni , Rahul Kumar Subject: Re: [edk2-devel] [PATCH 2/6] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue Message-ID: <20230306071353.emffhjveescrzh6g@sirius.home.kraxel.org> References: <20230303100336.2138-1-dun.tan@intel.com> <20230303100336.2138-3-dun.tan@intel.com> MIME-Version: 1.0 In-Reply-To: <20230303100336.2138-3-dun.tan@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 03, 2023 at 06:03:32PM +0800, duntan wrote: > Fix the non-1:1 mapping issue in PageTableMap () of CpuPageTableLib This needs a more verbose commit message. It's not clear what the bug is and how you are fixing it. take care, Gerd