From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by mx.groups.io with SMTP id smtpd.web10.28798.1678091881515890532 for ; Mon, 06 Mar 2023 00:38:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=HxFWtPpw; spf=pass (domain: 9elements.com, ip: 209.85.208.47, mailfrom: patrick.rudolph@9elements.com) Received: by mail-ed1-f47.google.com with SMTP id j11so15628467edq.4 for ; Mon, 06 Mar 2023 00:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1678091880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8QkSQdXAQHtb7LTLLvp7nOPSqvKI/+cJ5azWwN/u1fU=; b=HxFWtPpwOEmwOmJ1H+3OP/0b1iQZnNaPMR+AsJRi5oUFhiVhDWHF+ZmxDLiARsxOsf wn+BkL2/2i8AA2Yk23sMfZp4rWWl8HcXCF051ufXZv+pr2fJ6LtJNtMn97jQygAN0rmP KPibddBm2geTtOy0AHT7iQdHt4q9FgkW5ADIEsejKMia6iecvk9YFp57+8t11qoDPMqS QkT4wv0B/yt83gs0WlUSr0S0SRzjNhdEpA6Fwg2eCBLxd8REin9g8T0i7EJwkr+TtxDX EDI+UNa/rJGQdlhLuyx/I3fe2BJ0M6UMMwJSsmLNOuUI1+snL6kCCLR/gxxy3pPDs9nG xmzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678091880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8QkSQdXAQHtb7LTLLvp7nOPSqvKI/+cJ5azWwN/u1fU=; b=klkoVsIuEWDCuuFgrhmOvEYBl3sVr85vDVAXcdpFylK1ZU29zS0D7d0j15HBdNJ3qf 5MyDpsL7T71kvxyX9iRbqfCDeaJKKBz28U0RDskppDxx9Ji3eQU6+4cVq4NGY93DnYyx RjMQakwFFTssErb8sWVBfh7RH2CJWiMFOibLj6GRTbgB6GZRihAXI2OvRcJxSNHAdG3v Jk4Ikvb+G3gGHk4M/IXIOf5rRTCnOiAe1B7dwRv6lyfYq70r7mgWreUunDKoXA7UE62o wRzvwPA77yKntRuQrAZ2TXjscLT+F4EDdaVbbWtQsqjJZMAHsiPrV6yAXlsuZj00g6Rv 3jDg== X-Gm-Message-State: AO0yUKVfHOlAqCHC2hAmDH1LiHLW2isZmiB020sr3nlSAF/48mefTMC4 taOzxo0nIk/y1LuysTbdi8qX7h+qyk87maZccuI= X-Google-Smtp-Source: AK7set+n/GhLhFbxPXpzXX+hZscRqpfQCXwoo3Rn2QKxeI1mc0Et30Y6UKfrLUFzfCxlWDxHy1iwiA== X-Received: by 2002:a17:906:f47:b0:907:6af1:a90 with SMTP id h7-20020a1709060f4700b009076af10a90mr9344156ejj.9.1678091879885; Mon, 06 Mar 2023 00:37:59 -0800 (PST) Return-Path: Received: from fedora.. (ip-095-222-150-251.um34.pools.vodafone-ip.de. [95.222.150.251]) by smtp.gmail.com with ESMTPSA id hy3-20020a1709068a6300b008e57b5e0ce9sm4250515ejc.108.2023.03.06.00.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 00:37:59 -0800 (PST) From: "Patrick Rudolph" To: Cc: devel@edk2.groups.io, guo.dong@intel.com, ray.ni@intel.com, sean@starlabs.systems, james.lu@intel.com, gua.guo@intel.com Subject: [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64 Date: Mon, 6 Mar 2023 09:37:56 +0100 Message-Id: <20230306083757.26274-2-patrick.rudolph@9elements.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306083757.26274-1-patrick.rudolph@9elements.com> References: <20230306083757.26274-1-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Drop the "-z max-page-size=3D0x40" option as it causes the ELF header to overflow into the .text section, causing undefined behaviour. With high optimization level it corrupts essential code and the binary would crash. It might work with low optimization level though. As the default is to use Oz and LTO, it always crashes. Test: The ELF generated by 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' boots. Signed-off-by: Patrick Rudolph Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4357 --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.t= emplate index 9b59bd75c3..0c584ab390 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -2866,7 +2866,7 @@ DEFINE CLANGDWARF_X64_PREFIX =3D ENV(CLANG_BIN) =0D # LLVM/CLANG doesn't support -n link option. So, it can't share the same I= A32_X64_DLINK_COMMON flag.=0D # LLVM/CLANG doesn't support common page size. So, it can't share the same= GccBase.lds script.=0D -DEFINE CLANGDWARF_IA32_X64_DLINK_COMMON =3D -nostdlib -Wl,-q,--gc-sectio= ns -z max-page-size=3D0x40=0D +DEFINE CLANGDWARF_IA32_X64_DLINK_COMMON =3D -nostdlib -Wl,-q,--gc-sectio= ns=0D DEFINE CLANGDWARF_DLINK2_FLAGS_COMMON =3D -Wl,--script=3D$(EDK_TOOLS_P= ATH)/Scripts/ClangBase.lds=0D DEFINE CLANGDWARF_IA32_X64_ASLDLINK_FLAGS =3D DEF(CLANGDWARF_IA32_X64_DLIN= K_COMMON) -Wl,--defsym=3DPECOFF_HEADER_SIZE=3D0 DEF(CLANGDWARF_DLINK2_FLAGS= _COMMON) -Wl,--entry,ReferenceAcpiTable -u ReferenceAcpiTable=0D DEFINE CLANGDWARF_IA32_X64_DLINK_FLAGS =3D DEF(CLANGDWARF_IA32_X64_DLIN= K_COMMON) -Wl,--entry,$(IMAGE_ENTRY_POINT) -u $(IMAGE_ENTRY_POINT) -Wl,-Map= ,$(DEST_DIR_DEBUG)/$(BASE_NAME).map,--whole-archive=0D --=20 2.39.1