From: "Tuan Phan" <tphan@ventanamicro.com>
To: devel@edk2.groups.io
Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn,
zhiguang.liu@intel.com, sunilvl@ventanamicro.com,
git@danielschaefer.me, andrei.warkentin@intel.com,
Tuan Phan <tphan@ventanamicro.com>
Subject: [PATCH 4/7] OvmfPkg/RiscVVirt: VirtNorFlashPlatformLib: Fix wrong flash size
Date: Mon, 6 Mar 2023 09:33:13 -0800 [thread overview]
Message-ID: <20230306173316.10319-5-tphan@ventanamicro.com> (raw)
In-Reply-To: <20230306173316.10319-1-tphan@ventanamicro.com>
The size should be for single region, not the whole firmware FD.
Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
---
.../Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c b/OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c
index fdc2ccb6294e..067065bd6ef9 100644
--- a/OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c
+++ b/OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c
@@ -24,7 +24,8 @@ VIRT_NOR_FLASH_DESCRIPTION mNorFlashDevice =
{
FixedPcdGet32 (PcdOvmfFdBaseAddress),
FixedPcdGet64 (PcdFlashNvStorageVariableBase),
- FixedPcdGet32 (PcdOvmfFirmwareFdSize),
+ FixedPcdGet32 (PcdOvmfFirmwareFdSize) -
+ (FixedPcdGet64 (PcdFlashNvStorageVariableBase) - FixedPcdGet32 (PcdOvmfFdBaseAddress)),
QEMU_NOR_BLOCK_SIZE
};
--
2.25.1
next prev parent reply other threads:[~2023-03-06 17:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 17:33 [PATCH 0/7] RISC-V: Add MMU support Tuan Phan
2023-03-06 17:33 ` [PATCH 1/7] MdePkg/BaseLib: RISC-V: Support getting satp register value Tuan Phan
2023-03-06 17:33 ` [PATCH 2/7] MdePkg/Register: RISC-V: Add satp mode bits shift definition Tuan Phan
2023-03-06 17:33 ` [PATCH 3/7] UefiCpuPkg: RISC-V: Support MMU with SV39/48/57 mode Tuan Phan
2023-03-06 17:33 ` Tuan Phan [this message]
2023-03-06 17:33 ` [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists Tuan Phan
2023-03-06 17:53 ` [edk2-devel] " Ard Biesheuvel
2023-05-24 18:13 ` Tuan Phan
2023-05-25 14:27 ` Ard Biesheuvel
2023-05-25 14:44 ` Tuan Phan
2023-03-06 17:33 ` [PATCH 6/7] OvmfPkg/RiscVVirt: SEC: Add IO memory resource hob for platform devices Tuan Phan
2023-03-06 17:33 ` [PATCH 7/7] OvmfPkg/RiscVVirt: Enable MMU with SV39 mode Tuan Phan
2023-03-09 0:46 ` Andrei Warkentin
2023-03-09 19:19 ` [PATCH 0/7] RISC-V: Add MMU support Tuan Phan
2023-03-09 21:34 ` Andrei Warkentin
2023-03-10 22:20 ` Tuan Phan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306173316.10319-5-tphan@ventanamicro.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox