public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ajay Kadapathri" <ajay.kadapathri@intel.com>
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Jayaprakash N <n.jayaprakash@intel.com>
Subject: [edk2-libc Patch 2/2] Incorporated review comments
Date: Tue,  7 Mar 2023 10:41:50 +0530	[thread overview]
Message-ID: <20230307051150.772-3-ajay.kadapathri@intel.com> (raw)
In-Reply-To: <20230307051150.772-1-ajay.kadapathri@intel.com>

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jayaprakash N <n.jayaprakash@intel.com>
Signed-off-by: Ajay Kadapathri <ajay.kadapathri@intel.com>
---
 .../PyMod-3.6.8/Modules/edk2module.c          | 26 +++++++++----------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
index a0e6273..4c400b9 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
+++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
@@ -4257,26 +4257,24 @@ MiscRT_SetVariable(PyObject *self, PyObject *args)
 }
 
 
+/**
+  This function prints a GUID to a buffer
+  
+  @param guid                    Pointer to a GUID
+  
+  @param str_buffer              Pointer to a str buffer
+  
+
+  @retval EFI_SUCCESS            GUID was printed
+  
+  @retval EFI_INVALID_PARAMETER  GUID was NULL
 
+**/
 EFI_STATUS
 GuidToStr (
   IN EFI_GUID  *guid,
   IN OUT UINT8 *str_buffer
   )
-/*++
-
-Routine Description:
-  This function prints a GUID to a buffer
-
-Arguments:
-  guid       - Pointer to a GUID
-  str_buffer - Pointer to a str buffer
-
-Returns:
-  EFI_SUCCESS            GUID was printed
-  EFI_INVALID_PARAMETER  GUID was NULL
-  
---*/
 {
   if (guid == NULL) {
     return EFI_INVALID_PARAMETER;
-- 
2.39.1.windows.1


  parent reply	other threads:[~2023-03-07  5:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07  5:11 [edk2-libc Patch 0/2] Python/Python3.6.8: migration of edk2module from chipsec repo Ajay Kadapathri
2023-03-07  5:11 ` [edk2-libc Patch 1/2] " Ajay Kadapathri
2023-03-07  5:11 ` Ajay Kadapathri [this message]
2023-03-07 16:50   ` [edk2-devel] [edk2-libc Patch 2/2] Incorporated review comments Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307051150.772-3-ajay.kadapathri@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox