From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.8872.1678171808712228610
 for <devel@edk2.groups.io>;
 Mon, 06 Mar 2023 22:50:09 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UM8osii7;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1678171807;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=H2pSNKFW1dGnmfa1g/giElMU4Fgy8aPcma8molPJFY8=;
	b=UM8osii7RJPtR3EdhLxX1K0hafp64YXlI24Hm/N7HKgHWpcDpB1uCqIWRpD4t8LvehlwH7
	dC8/Jy+XzDFxxwSR5dDMF4+G7zObDfX1whrJy7IfevIJSBiDmQVujgNDIWdpD6hNPuP6O6
	ijDdXyKY86K8yd6YUc9kSinunwL7gVQ=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-275-f1oOJlEOOAe_AlUCMd3AEQ-1; Tue, 07 Mar 2023 01:50:04 -0500
X-MC-Unique: f1oOJlEOOAe_AlUCMd3AEQ-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB7F585C70E;
	Tue,  7 Mar 2023 06:50:03 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.23])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id B0AA82166B26;
	Tue,  7 Mar 2023 06:50:03 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 57E99180061C; Tue,  7 Mar 2023 07:50:02 +0100 (CET)
Date: Tue, 7 Mar 2023 07:50:02 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>,
	Star Zeng <star.zeng@intel.com>,
	Mike Maslenkin <mike.maslenkin@gmail.com>
Subject: Re: [PATCH v2] UefiCpuPkg: Calculate DisplayFamily correctly
Message-ID: <20230307065002.3dt3bgsshzseolhe@sirius.home.kraxel.org>
References: <20230307063136.1615-1-zhiguang.liu@intel.com>
MIME-Version: 1.0
In-Reply-To: <20230307063136.1615-1-zhiguang.liu@intel.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 07, 2023 at 02:31:36PM +0800, Zhiguang Liu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4348
> 
> Per SDM:
> DisplayFamily = Extended_Family_ID + Family_ID.
> DisplayModelID = (Extended_Model_ID << 4) + Family_ID.
> Correct the related code.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Reviewed-by: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Star Zeng <star.zeng@intel.com>
> Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>