public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io
Cc: ardb+tianocore@kernel.org, leif@nuviainc.com,
	sami.mujawar@arm.com, Jiewen Yao <jiewen.yao@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>
Subject: [PATCH v4 0/2] SecurityPkg: Fixes for RngDxe
Date: Tue,  7 Mar 2023 18:15:48 +0100	[thread overview]
Message-ID: <20230307171550.555541-1-pierre.gondois@arm.com> (raw)

From: Pierre Gondois <pierre.gondois@arm.com>

v1:
- https://edk2.groups.io/g/devel/message/96356
v2:
- https://edk2.groups.io/g/devel/message/96434
- Reformulate commit message.
- Do not warn if no algorithm is found as the message
  would be printed on non-Arm platforms.
v3:
- https://edk2.groups.io/g/devel/topic/95240503
- Add the following patches:
  1. ArmPkg/ArmTrngLib: Remove ASSERTs in ArmTrngLibConstructor()
     Requested by Ard.
     Cf https://edk2.groups.io/g/devel/message/96495
  2. SecurityPkg/RngDxe: Conditionally install EFI_RNG_PROTOCOL
     Do not install EFI_RNG_PROTOCOL if no RNG algorithm is available.
     Cf. https://edk2.groups.io/g/devel/message/96494
  3. SecurityPkg/RngDxe: Fix Rng algo selection for Arm
     Coming from v2 patch being split.
v4:
- Change description of:
   'SecurityPkg/RngDxe: Fix Rng algo selection for Arm'
  to:
   'SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm'
- Add patch:
    'SecurityPkg/RngDxe: Check for NULL PcdCpuRngSupportedAlgorithm'
- Remove as merged:
    SecurityPkg/RngDxe: Conditionally install EFI_RNG_PROTOCOL
    SecurityPkg/RngDxe: Correctly update mAvailableAlgoArrayCount

When adding support for the Firmware Trng interface, it was made
available through in the RngDxe module. In RngDxe, the algorithm
associated with PcdCpuRngSupportedAlgorithm (implemented by the
RngLib) was always advertised by default.

It was assumed that support for RngLib and RNDR instructions
should be kept in ArmVirtPkg. However this support did not exist
as all ArmVirtPkg use the BaseRngLibTimerLib.inf implementation
of the RngLib.

Do not advertise the RngLib and PcdCpuRngSupportedAlgorithm
if PcdCpuRngSupportedAlgorithm is NULL.

Also simplify the selection of the default algorithm.

Pierre Gondois (2):
  SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm
  SecurityPkg/RngDxe: Check for NULL PcdCpuRngSupportedAlgorithm

 .../RngDxe/AArch64/AArch64Algo.c                | 14 +++-----------
 .../RandomNumberGenerator/RngDxe/ArmRngDxe.c    | 17 ++++-------------
 2 files changed, 7 insertions(+), 24 deletions(-)

-- 
2.25.1


             reply	other threads:[~2023-03-07 17:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 17:15 PierreGondois [this message]
2023-03-07 17:15 ` [PATCH v4 1/2] SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm PierreGondois
2023-03-07 17:15 ` [PATCH v4 2/2] SecurityPkg/RngDxe: Check for NULL PcdCpuRngSupportedAlgorithm PierreGondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307171550.555541-1-pierre.gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox