From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mx.groups.io with SMTP id smtpd.web11.187.1678317535804547515 for ; Wed, 08 Mar 2023 15:18:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Z59i25CQ; spf=pass (domain: gmail.com, ip: 209.85.208.172, mailfrom: mike.maslenkin@gmail.com) Received: by mail-lj1-f172.google.com with SMTP id i20so19703lja.11 for ; Wed, 08 Mar 2023 15:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678317534; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QE41RrTSPFAztTxznohxswPtqIZQSR8FTcTKdKieBvs=; b=Z59i25CQuqIz2kOQqzFa/CF1MYfa4O4h427llMalxnEg8nK6MSQMVrVYLRaCRWp8Xc i34uYMGbhmdJiOx0/13IAIA99VIIKT8/3c6NK6Gu1Siri1gdrZL+zoy1UfYnGVVMPuLf 8rnrPqUPfnHfKTwoH1BqK4mPJplVtGvmucVsa5Qx931Wm4pxVA8J/orQE790qrUexl8U rnV3tYRdjwvBtrfmxVHjkfWlZzMsDBJWnLEi7+gV7GSrL2dLunP9JGA8gcFqm4BPHmZy aDfPIMYYDjUP3/IFrMp9sA/d1VK6kkluvdA4k3dSwn7iiqB6moinH0XcZpq4Iohb0SnU t9Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678317534; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QE41RrTSPFAztTxznohxswPtqIZQSR8FTcTKdKieBvs=; b=1gnuJzXkH4SNwMgxqUWWu+FCRQ0zeiUIx6ZMT9vdNQmK5g+QBetipcH51OOl+2evhw 6h+oJzIjjEbMf5RpapztbUcD3diHQVfQC8Il8Hz0fDMOgsswZtDEaJqaOBv3aoc/YeeX SBmswXowiL9UBNwgWElhmCsS9l7ftVbsz1TEVyPsDb8Z6NiFLLS9Truydd4F4BM6QpLt kvVETB129230aiwt3nE6RZ8Z92tKadnLOpCzIxBFQ4CMRgB9eDnlH9XVgYhTTf7Mow5E H+H9bw+GPI50XUnRutneEsYgD1+4kWtiAiH6MUSBc0nch02B8998gBTdCZy9vhhq4vCi Kd1g== X-Gm-Message-State: AO0yUKUXncFihenMnZg7CRLq4E1QpffY/PRbfVz7J56Ps/UyDfN7jFoJ 508BbBFkfUUb8qKvX8wg9HrYbci21DkwCX4ID5A= X-Google-Smtp-Source: AK7set9qgmLjhM/OnkBFl21Mx7vMG83LZctuw+KTG72uBdx834nstKJySGHJE35szuXSm5XkMm/Y/Q== X-Received: by 2002:a2e:a583:0:b0:295:d385:88cd with SMTP id m3-20020a2ea583000000b00295d38588cdmr7362973ljp.19.1678317533841; Wed, 08 Mar 2023 15:18:53 -0800 (PST) Return-Path: Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id w11-20020a05651c102b00b00293526a0c87sm2726630ljm.41.2023.03.08.15.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 15:18:53 -0800 (PST) From: "Mike Maslenkin" To: Cc: devel@edk2.groups.io, Mike Maslenkin , Isaac Oram , Nate DeSimone , Liming Gao Subject: [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response Date: Thu, 9 Mar 2023 02:18:42 +0300 Message-Id: <20230308231845.10895-1-mike.maslenkin@gmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patchset fixes "Get Self Test Results" IPMI command response processing. The first patch just makes a fix. The second patch removes a transfer buffer from IPMI instance data as a preparation of further improvement. It's not clear why a buffer of a maximum size used for all commands. For the command mentioned above response contains only 3 bytes. The third patch drops raw byte array usage while parsing command response because structure for this response is already defined in edk2. Checked compilation for the Intel’s Aowanda platform using GCC5 toolchain. v2: patch 1: added R-b patch 2: added changes to SmmGenericIpmi.c patch 3: renamed pSelfTestResult to SelfTestResult, fixed initialization of SelfTestResult->CompletionCode before IpmiSendCommand call. Signed-off-by: Mike Maslenkin Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao