public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Ni, Ray" <ray.ni@intel.com>, "Dong, Eric" <eric.dong@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process
Date: Fri, 10 Mar 2023 11:01:20 +0100	[thread overview]
Message-ID: <20230310100120.bfl3wz6qpwh2i5nm@sirius.home.kraxel.org> (raw)
In-Reply-To: <MN0PR11MB6158AE46C15AAB586A4A9A9DFEBA9@MN0PR11MB6158.namprd11.prod.outlook.com>

On Fri, Mar 10, 2023 at 09:19:04AM +0000, Wu, Jiaxin wrote:
> Is this regression? I remember I tried the S3 on real silicon with the patch change, don't see the issue in normal boot work flow. The only difference what I did is to trigger S3 in the BIOS shell, but it does covered the SmmRestoreCpu test. 
> 
> Now, I'm trying to reproduce the issue on ovmf, and build the OVMF boot on windows qemu, but I saw below error during boot:
> SecCoreStartupWithStack(0xFFFCC000, 0x820000)
> ASSERT [SecMain] c:\dev\code\edk2\MdePkg\Library\BasePcdLibNull\PcdLib.c(95): ((BOOLEAN)(0==1))
> 
> Build command is:
> build -p OvmfPkg\OvmfPkgIa32X64.dsc -a X64 -D SMM_REQUIRE -D DEBUG_ON_SERIAL_PORT -D SOURCE_DEBUG_ENABLE
> 
> Run qemu command is:
> qemu-system-x86_64 -bios  C:\Dev\Code\edk2\Build\Ovmf3264\DEBUG_VS2015x86\FV\OVMF.fd -hda fat:rw:hda-contents -serial file:log001.log -net none

Mine is this:

qemu-system-x86_64 -enable-kvm -machine q35,smm=on -m 4G -net none \
	-drive if=pflash,format=raw,file=Build/Ovmf3264/DEBUG_GCC5/FV/OVMF_CODE.fd,readonly=on \
	-drive if=pflash,format=raw,file=Build/Ovmf3264/DEBUG_GCC5/FV/OVMF_VARS.fd,snapshot=on \
	-chardev vc,id=fw.log -device isa-debugcon,iobase=0x402,chardev=fw.log \
	-cdrom /vmdisk/iso/Fedora-Workstation-Live-x86_64-37-1.7.iso \
	-device virtio-tablet-pci \
	-display gtk,show-tabs=on

> Anything need to be care to build OvmfPkgIa32X64?

It must be started with the correct flash configuration, see above.
The SMM-enabled builds also require the q35 machine type.

I have both SMM_REQUIRE and SECURE_BOOT enabled, that probably doesn't
make a difference though.  I'm using the isa-debugcon instead of the
serial port to get the debug log, that should not matter either.

> BTW, how can I boot linux guest in windows qemu?

Just grab some live iso.  The fedora image used above is available from
getfedora.org, but any live image should work.

How do you trigger suspend from efi shell?  There seems to be no
builtin command for that.

take care,
  Gerd


  reply	other threads:[~2023-03-10 10:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <17443983D6ED8995.20300@groups.io>
2023-02-20  1:06 ` [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process Wu, Jiaxin
2023-02-20  1:14   ` Ni, Ray
2023-02-21  8:48     ` Gerd Hoffmann
2023-02-21  9:12       ` Ni, Ray
2023-02-21  9:45         ` Gerd Hoffmann
2023-03-06 11:13       ` Gerd Hoffmann
2023-03-06 11:43         ` Ni, Ray
2023-03-06 13:20           ` Gerd Hoffmann
2023-03-10  9:19             ` Wu, Jiaxin
2023-03-10 10:01               ` Gerd Hoffmann [this message]
2023-03-10 10:17                 ` Wu, Jiaxin
2023-03-10 10:29                 ` Wu, Jiaxin
2023-03-10 11:19                   ` Gerd Hoffmann
2023-03-13  5:50                 ` Wu, Jiaxin
2023-02-20  2:37   ` Michael D Kinney
2023-02-20  2:57     ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310100120.bfl3wz6qpwh2i5nm@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox