From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.15692.1678442488444597816 for ; Fri, 10 Mar 2023 02:01:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T6fBSw3f; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678442486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7/tYFAbWAysTZciZUL9jLkjSsCufYoDLpH7bEk4CxdU=; b=T6fBSw3f4+c8Ye00nY11dmRlkcTvxx9lT1RGcQLqQw+7iiOg2sO7v5SO1Qm+Qg/d/pNj3S cMaiQHq2wsmFbleV/Wq+aATKo5/KM6eDbpOPDv8VxR/KVmQIom2XYSCnu71kQy0FselPAQ IFUuNybnkPhNI8kAwQb75cr1jcuC3IM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-u6a0ITafPT67d3w6Z0N40w-1; Fri, 10 Mar 2023 05:01:25 -0500 X-MC-Unique: u6a0ITafPT67d3w6Z0N40w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 197A03C0F19A; Fri, 10 Mar 2023 10:01:25 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8E4340BC781; Fri, 10 Mar 2023 10:01:24 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7EEEA1800982; Fri, 10 Mar 2023 11:01:20 +0100 (CET) Date: Fri, 10 Mar 2023 11:01:20 +0100 From: "Gerd Hoffmann" To: "Wu, Jiaxin" Cc: "devel@edk2.groups.io" , "Ni, Ray" , "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process Message-ID: <20230310100120.bfl3wz6qpwh2i5nm@sirius.home.kraxel.org> References: <17443983D6ED8995.20300@groups.io> <20230221084854.ckcwtl4tt3onq623@sirius.home.kraxel.org> <20230306111315.pmglh65rd42llsue@sirius.home.kraxel.org> <20230306132037.seboq5tdsouqgrs4@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 10, 2023 at 09:19:04AM +0000, Wu, Jiaxin wrote: > Is this regression? I remember I tried the S3 on real silicon with the patch change, don't see the issue in normal boot work flow. The only difference what I did is to trigger S3 in the BIOS shell, but it does covered the SmmRestoreCpu test. > > Now, I'm trying to reproduce the issue on ovmf, and build the OVMF boot on windows qemu, but I saw below error during boot: > SecCoreStartupWithStack(0xFFFCC000, 0x820000) > ASSERT [SecMain] c:\dev\code\edk2\MdePkg\Library\BasePcdLibNull\PcdLib.c(95): ((BOOLEAN)(0==1)) > > Build command is: > build -p OvmfPkg\OvmfPkgIa32X64.dsc -a X64 -D SMM_REQUIRE -D DEBUG_ON_SERIAL_PORT -D SOURCE_DEBUG_ENABLE > > Run qemu command is: > qemu-system-x86_64 -bios C:\Dev\Code\edk2\Build\Ovmf3264\DEBUG_VS2015x86\FV\OVMF.fd -hda fat:rw:hda-contents -serial file:log001.log -net none Mine is this: qemu-system-x86_64 -enable-kvm -machine q35,smm=on -m 4G -net none \ -drive if=pflash,format=raw,file=Build/Ovmf3264/DEBUG_GCC5/FV/OVMF_CODE.fd,readonly=on \ -drive if=pflash,format=raw,file=Build/Ovmf3264/DEBUG_GCC5/FV/OVMF_VARS.fd,snapshot=on \ -chardev vc,id=fw.log -device isa-debugcon,iobase=0x402,chardev=fw.log \ -cdrom /vmdisk/iso/Fedora-Workstation-Live-x86_64-37-1.7.iso \ -device virtio-tablet-pci \ -display gtk,show-tabs=on > Anything need to be care to build OvmfPkgIa32X64? It must be started with the correct flash configuration, see above. The SMM-enabled builds also require the q35 machine type. I have both SMM_REQUIRE and SECURE_BOOT enabled, that probably doesn't make a difference though. I'm using the isa-debugcon instead of the serial port to get the debug log, that should not matter either. > BTW, how can I boot linux guest in windows qemu? Just grab some live iso. The fedora image used above is available from getfedora.org, but any live image should work. How do you trigger suspend from efi shell? There seems to be no builtin command for that. take care, Gerd