From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mx.groups.io with SMTP id smtpd.web10.42924.1678534236311880563 for ; Sat, 11 Mar 2023 03:30:36 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=efXymCAt; spf=pass (domain: gmail.com, ip: 209.85.208.171, mailfrom: mike.maslenkin@gmail.com) Received: by mail-lj1-f171.google.com with SMTP id b10so8040314ljr.0 for ; Sat, 11 Mar 2023 03:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678534234; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VyNoHe4LWXXm4blMCBX4X7NuPvh6PMCDmMenIbzLEv0=; b=efXymCAtfthtytmXNL+weBwUzerJjTvPMf9b/TFM+qkp1PwxyTFGkrXzrkGCvBKh6U chsIwHHuNCGV0xnYyR5PyhXlDQXr0KYYa3un6EJCsQYmruBJS7zdGIAypd54eXSmgX0G YCxQQPvJCG+lZOm3w9k1QK9p9La9qWCnm9xT6gMKIPIh2LPfegF3cpMRTSPl0iSwhWUf 7S7Z9CeSGt30uDN4E6sw4OE+ta0Ii8PwT0JAh1Huc9NCTw0AecbKyCQwHtBJFOd3aRks Uo9iNPmjWAjlfjH97uahZMMgVP9FcAh8ZBbfU06/kjhEYhkgRSzQaODvnDVNZU26fZ7u KO0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678534234; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VyNoHe4LWXXm4blMCBX4X7NuPvh6PMCDmMenIbzLEv0=; b=tR6gvY/8DDapqgaZJlaJnz0oBPPR3Z/srbcPmVCTRsh8YMJWt/IOQYXS6taq4M5Gg3 JW/gs8wr3C6ZBnzfOayJiA0vnYj85mPm48ivU3Oxk38eOTxkIbIAM73hMnTMwuc1sQ3g ZakrfaO31k82D7GXMRShtarkOljld92KRnw2Es9tRk77hA1bXkNV9m96tXQNa/dPWcr6 UQ5sal5pTLyvepHRoRrduo9QgAoDQRNPwppryA1irr2oweErm3kFK7Vno922/zETXW7b CvaB7N+7UHblv1Gcx7oGhuZKVDwweS/lF4eXcwxmpU4ca1/6YV84QRqebEW6cVXHGtp4 b6+g== X-Gm-Message-State: AO0yUKXxEYRvyo23TONmVO0iTpZ5H2S7He8AmbzFO8ZwYZ/BYlbCDdqe PDFDnDhhGR+j5lw3pvIfIX84R4gPi9PRfG0+3No= X-Google-Smtp-Source: AK7set+YMSr3J1/dG9IPArYD0ec6BVE9waRgvku9Em1ZoYrm4eYk4QWImQWWgwQ/XTIT4imMxpI+BQ== X-Received: by 2002:a2e:86d6:0:b0:290:6e31:dbfb with SMTP id n22-20020a2e86d6000000b002906e31dbfbmr8194377ljj.28.1678534234344; Sat, 11 Mar 2023 03:30:34 -0800 (PST) Return-Path: Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id v27-20020a056512049b00b004db44e91e34sm291883lfq.43.2023.03.11.03.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 03:30:33 -0800 (PST) From: "Mike Maslenkin" To: Cc: devel@edk2.groups.io, Mike Maslenkin , Isaac Oram , Nate DeSimone , Liming Gao Subject: [PATCH edk2-platforms 2/2] IpmiFeaturePkg: fix IpmiSendCommand response size in GetDeviceId function Date: Sat, 11 Mar 2023 14:30:06 +0300 Message-Id: <20230311113006.18957-3-mike.maslenkin@gmail.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230311113006.18957-1-mike.maslenkin@gmail.com> References: <20230311113006.18957-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable It is required to reinitialize DataSize variable before subsequent IpmiSendCommand calls. It is especially required after processing IpmiSendCommand with IPMI_GET_BMC_EXECUTION_CONTEXT because it returns only 2 bytes as a response. So to the next call of IpmiSendCommand with IPMI_APP_GET_DEVICE_ID DataSize=3D2 will be passed. Probably this call will fail because the expected size of returned data either 12 or 16 bytes depending on IPMI version supported. Signed-off-by: Mike Maslenkin Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 5bdbe47b6acb..c333ca2e067a 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c @@ -305,6 +305,7 @@ Returns: mIpmiInstance->BmcStatus =3D BMC_OK;=0D return EFI_SUCCESS;=0D } else {=0D + DataSize =3D sizeof (TempData);=0D Status =3D IpmiSendCommand (=0D &IpmiInstance->IpmiTransport,=0D IPMI_NETFN_FIRMWARE, 0,=0D @@ -326,6 +327,7 @@ Returns: while (Retries-- !=3D 0) {=0D MicroSecondDelay(1*1000*1000); //delay 1 seconds=0D DEBUG ((EFI_D_ERROR, "[IPMI] UpdateMode Retries: %d \n",Retries));= =0D + DataSize =3D sizeof (TempData);=0D Status =3D IpmiSendCommand (=0D &IpmiInstance->IpmiTransport,=0D IPMI_NETFN_APP, 0,=0D --=20 2.32.0 (Apple Git-132)