From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.14347.1678694427189923052
 for <devel@edk2.groups.io>;
 Mon, 13 Mar 2023 01:00:27 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JxJNeLOH;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1678694426;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=mZ5kQjRhRF+abo9TqhoOCOc734aXuAXGPU612NC3/h0=;
	b=JxJNeLOHGGoOdv2Uiie0bOkRw4/N3AXOD9cg+6mzpOT2TcJr1gYpQeQIjt31hRhi5EjLWK
	LyrRkK/0K9Jqu0xAt6qMAmF9zcTKxZTC8YvuwMp09PUmAoqHAc2IBKyXSoEJ+X71P91po7
	bZiGVoSUSgW2M9NC5isL/v/phDE5WF8=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-553-GOA4N5tXP6Ospb0FUFKCZg-1; Mon, 13 Mar 2023 04:00:23 -0400
X-MC-Unique: GOA4N5tXP6Ospb0FUFKCZg-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8403C1C294E4;
	Mon, 13 Mar 2023 08:00:22 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.142])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 15725492C13;
	Mon, 13 Mar 2023 08:00:22 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id B26471801CF6; Mon, 13 Mar 2023 09:00:20 +0100 (CET)
Date: Mon, 13 Mar 2023 09:00:20 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: devel@edk2.groups.io, Eric Dong <eric.dong@intel.com>,
	Ray Ni <ray.ni@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>,
	Michael Roth <michael.roth@amd.com>,
	Ashish Kalra <Ashish.Kalra@amd.com>
Subject: Re: [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned
Message-ID: <20230313080020.z7vdonl4wonlp3hq@sirius.home.kraxel.org>
References: <cover.1678467840.git.thomas.lendacky@amd.com>
 <0ae6206c682709f09214222bd597d4aa6578c56a.1678467840.git.thomas.lendacky@amd.com>
MIME-Version: 1.0
In-Reply-To: <0ae6206c682709f09214222bd597d4aa6578c56a.1678467840.git.thomas.lendacky@amd.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

>    // Allocate a single page for the SEV-ES Save Area and initialize it.
> +  // Due to an erratum that prevents a VMSA being on a 2MB boundary,
> +  // allocate an extra page to work around the issue.

A reference to the erratum (web link or erratum id) would be nice here.
Also swapping the order of the two patches might simplify the other
patch which happens to shuffle around the code this patch has just
added.

take care,
  Gerd