From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.3541.1678779913489053914 for ; Tue, 14 Mar 2023 00:45:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LMSoqm0Y; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678779912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p6Dz/7qd2vAgy5ZmN5zCEeonXTe3zrG4hdcIwJvogHs=; b=LMSoqm0YdxxYvJeFEbkdx5ISiQtusosLkl4qgFMWRqjbxTO4eHNzI7L8RJ3Tz+RdgDN110 XOnSm7q0JPWopHlaTFLxpZe46itxiO1bAXng4m5kmb68G7FLcv4JqXjUjCQ59Ty/Ku/zcE N6BcLoJoHkbK/0SDS9V1ZBZ+GbO27uE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-56-q4KqbGqzNTebaiWrepAXDA-1; Tue, 14 Mar 2023 03:45:08 -0400 X-MC-Unique: q4KqbGqzNTebaiWrepAXDA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6E8D91C09040; Tue, 14 Mar 2023 07:45:08 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4247F140EBF4; Tue, 14 Mar 2023 07:45:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 14B0D1801E88; Tue, 14 Mar 2023 08:45:07 +0100 (CET) Date: Tue, 14 Mar 2023 08:45:07 +0100 From: "Gerd Hoffmann" To: "Li, Yi1" Cc: "devel@edk2.groups.io" , "Wang, Jian J" , Pawel Polawski , "Lu, Xiaoyu1" , Ard Biesheuvel , "Jiang, Guomin" , "Yao, Jiewen" , Oliver Steffen , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH 16/22] [hash] CryptoPkg/openssl: add OpensslLibHash.inf Message-ID: <20230314074507.olwxsdyktwrjezua@sirius.home.kraxel.org> References: <20230313083016.136448-1-kraxel@redhat.com> <20230313083016.136448-17-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 13, 2023 at 03:46:25PM +0000, Li, Yi1 wrote: > A bit confused here, why we need this inf, just to make it clear? > As you mentioned, it doesn't help with binary file size. As the commit message says it helps to figure where the bloat comes because you get error messages for missing symbols instead of a huge binary. That has lead to this patch series: https://github.com/tianocore/edk2/pull/4104 But we don't have to keep it, not sure how much value that has given the cause has been found and fixed. take care, Gerd