From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.3632.1678780551387452617 for ; Tue, 14 Mar 2023 00:55:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=V99hMmup; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678780550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qyfs241gR/pxtzslw6SYSrz9lpAHHPw+KFCy7uPKR9w=; b=V99hMmupD9m9nW5o2vHSZmjjY7m3NEBjvuOIxgrQEKzqwk3z+rLdaDm1xMLNA34SFg5uvK 3mfIJ3l2+vDJqNB67rylkxgOnR7fujxjC/WjCKfXegMFTTyZJ2+K1qs2v/7vaUaPOu56fh kk5U+1Kp+VOyQSQ4vs3rKogSSEhOHac= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-XaCbzBaNPqC5W2823O3lqg-1; Tue, 14 Mar 2023 03:55:47 -0400 X-MC-Unique: XaCbzBaNPqC5W2823O3lqg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E0E2811E6E; Tue, 14 Mar 2023 07:55:46 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5330E492B00; Tue, 14 Mar 2023 07:55:46 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1CF141801E88; Tue, 14 Mar 2023 08:55:45 +0100 (CET) Date: Tue, 14 Mar 2023 08:55:45 +0100 From: "Gerd Hoffmann" To: "Li, Yi1" Cc: "devel@edk2.groups.io" , "Wang, Jian J" , Pawel Polawski , "Lu, Xiaoyu1" , Ard Biesheuvel , "Jiang, Guomin" , "Yao, Jiewen" , Oliver Steffen , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH 19/22] CryptoPkg/openssl: update *.inf, add generated files Message-ID: <20230314075545.lsquiqwrk5h7ns7u@sirius.home.kraxel.org> References: <20230313083016.136448-1-kraxel@redhat.com> <20230313083016.136448-20-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 13, 2023 at 03:26:41PM +0000, Li, Yi1 wrote: > >+ DEFINE OPENSSL_FLAGS_NOASM = -DSTATIC_LEGACY > > > > Why we need this macro, EDK2 does not seem to use the algorithm in the legacy provider. Oh, that slipped into the wrong patch. The openssl Configure script adds that, and configure.py picks it up and adds it to OPENSSL_FLAGS_*. Should have been in the "update generated files" patch (which also updates the autogenerated content in *.inf). Yes, seems not be needed, but doesn't harm either and isn't worth a special case in configure.py ... take care, Gerd