From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.4270.1678784661354808289
 for <devel@edk2.groups.io>;
 Tue, 14 Mar 2023 02:04:21 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KMcWLRKq;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1678784659;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=DfKpOFXGJAVthfvqVIuMPsYrRX+hs0cysGM3eKeWgtA=;
	b=KMcWLRKqTrIUsevU2WGe5r1E7ykDh1Nqs1hxKQrbzLEhT4gQO6IyiQW5WpKakSYrj/CsRb
	/mCih70My9O2n+igxYl/UDl/ebUshDtCt4WYxgb69GC0ksAvqyMPiWtRZMWJpCCKmHJVvV
	y5731mGPaq1nkLx6Aw4iJZZIzZp1J+A=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-257-1exHJSlWP1e_WiakaNOuqw-1; Tue, 14 Mar 2023 05:04:12 -0400
X-MC-Unique: 1exHJSlWP1e_WiakaNOuqw-1
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A8F2A8828C2;
	Tue, 14 Mar 2023 09:04:10 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.142])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 627E3400F4F;
	Tue, 14 Mar 2023 09:04:10 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id DF3AF1801E88; Tue, 14 Mar 2023 10:04:08 +0100 (CET)
Date: Tue, 14 Mar 2023 10:04:08 +0100
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, yi1.li@intel.com,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Jiang, Guomin" <guomin.jiang@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	Oliver Steffen <osteffen@redhat.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH 01/22] CryptoPkg/openssl: update submodule to openssl-3.0.8
Message-ID: <20230314090408.harl52tmcy3mjapb@sirius.home.kraxel.org>
References: <20230313083016.136448-1-kraxel@redhat.com>
 <20230313083016.136448-2-kraxel@redhat.com>
 <SJ1PR11MB6227958F8645600B6F47F3C1C5B99@SJ1PR11MB6227.namprd11.prod.outlook.com>
 <20230314081612.7dze46duc3dn6wrw@sirius.home.kraxel.org>
 <CAMj1kXFqskVi-QApCA8qwhOV2wdvviX1cm8dyStgp9u6KZ+-aQ@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAMj1kXFqskVi-QApCA8qwhOV2wdvviX1cm8dyStgp9u6KZ+-aQ@mail.gmail.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> Yeah the SIGILL trapping is a bit nasty, but that is only used if no
> implementation of getauxval() exists.
> 
> So perhaps the cleanest way to approach this is to provide a dummy
> implementation of getauxval() which only supports AT_HWCAP, and
> returns the correct hwcap mask for what the CPU id registers report in
> terms for ISA support for crypto extensions.
> 
> I can code that up if you want.

Getting crypto/armcap.c even compile on edk2 will be a challenge I
think.  So I'd rather exclude it, and add a OPENSSL_cpuid_setup()
aarch64 implementation to edk2 and copy over the 10 lines which
map HWCAP -> OPENSSL_armcap_P.  That'll be alot easier than adding
dummy stubs for siglongjmp, sigaction & friends.

A hwcap query function would be helpful nevertheless.

thanks & take care,
  Gerd