From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, quic_rcran@quicinc.com
Cc: Andrew Fish <afish@apple.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Bob Feng <bob.c.feng@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Yuwei Chen <yuwei.chen@intel.com>,
Rebecca Cran <rebecca@quicinc.com>
Subject: Re: [edk2-devel] [PATCH 2/3] BaseTools: Improve detection of users wanting to build using clang
Date: Wed, 15 Mar 2023 11:11:24 +0100 [thread overview]
Message-ID: <20230315101124.d2v7b2d6x25hh7mg@sirius.home.kraxel.org> (raw)
In-Reply-To: <20230217035101.880854-3-rebecca@quicinc.com>
On Thu, Feb 16, 2023 at 08:51:00PM -0700, Rebecca Cran wrote:
> In https://bugzilla.tianocore.org/show_bug.cgi?id=2842 clang support was
> added by having users specify "make CXX=llvm" when building BaseTools.
>
> Improve the detection of when a user wants to use the clang toolchain:
> instead of checking if CXX=llvm (which in most cases doesn't make sense,
> because the C++ compiler won't be run via an 'llvm' command), run
> '$(CC) --version | grep clang' to see if the compiler's version string
> contains 'clang', and if so configure the environment.
>
> This provides flexibility to specify for example CC=clang-17
> CXX=clang++-17 if multiple versions are installed.
That totally makes sense. And maybe simply use 'cc' by default then?
take care,
Gerd
next prev parent reply other threads:[~2023-03-15 10:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 3:50 [PATCH 0/3] BaseTools: allow users to override CC and CXX on the make command line Rebecca Cran
2023-02-17 3:50 ` [PATCH 1/3] BaseTools: Allow users to specify compiler to use with make CC= CXX= Rebecca Cran
2023-03-15 10:07 ` [edk2-devel] " Gerd Hoffmann
2023-03-17 10:43 ` Rebecca Cran
2023-03-20 9:35 ` Gerd Hoffmann
2023-03-20 13:13 ` Rebecca Cran
2023-02-17 3:51 ` [PATCH 2/3] BaseTools: Improve detection of users wanting to build using clang Rebecca Cran
2023-03-15 10:11 ` Gerd Hoffmann [this message]
2023-02-17 3:51 ` [PATCH 3/3] BaseTools: Build against C++14 when building with clang Rebecca Cran
2023-03-15 10:11 ` [edk2-devel] " Gerd Hoffmann
2023-03-09 15:47 ` [edk2-devel] [PATCH 0/3] BaseTools: allow users to override CC and CXX on the make command line Rebecca Cran
[not found] ` <174ACADCDC6439C2.24021@groups.io>
2023-03-14 16:16 ` Rebecca Cran
2023-03-23 1:09 ` 回复: " gaoliming
[not found] ` <174EE719E87C3CB3.19937@groups.io>
2023-03-24 4:57 ` gaoliming
2023-03-24 21:39 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315101124.d2v7b2d6x25hh7mg@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox