From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.40]) by mx.groups.io with SMTP id smtpd.web10.6862.1678917501096471984 for ; Wed, 15 Mar 2023 14:58:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=uvPzoPul; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.40, mailfrom: michael.roth@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1HGLQOvTTgOHRHhaAEM02Z2KhLi694K7o6w1w6z/rScQQ4TwH1EN1qf5OmkQnhiOgDklX7XplwL4hywQyGRUrSw1F380EUAhkyxynC0pgAkWR4jhoz6DTEPzGMk3SRgaaTDrvVyBjlmafprv6Eq024NMnH7zTPuEFBUf8GpkzHFJvwypZBPW8l66MDMV3dI8pDGX3VymE90zvMzud27v+C9hm+sPDFkXShICB7a87ezriuI3nRIa6YP1MJRAKkGh5MLy7rUNmi5vroytCY5xyHaGQb/p8MPxawtG3Ia+d7FADt4ILUpeJ4J9ty5LdSU6mQnQ2K1pAzm4AYAbUD/Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DUjfLTjPKkm5MbP4Mn6W6X79x4eMXZ1G/HuE+f5hrl8=; b=OLVVLcTTfO2l2Lof54t9fqYhH6uN5YCjGpbIW6i7fB22eN0x0pFH9iZpfUDOxIqxp5StpwL0tve2MWBKODFwTabnCOugeQerRdNkItCUSb7eAbv/lrl8PPXJis7ZrlP0wan+Nvvyou/HS/qrTyIlSVRREOY0ruWr9YZYjRzVFspkm217uJqiytN2xcZP9npjU5xqNwyvyIfp3N2G4zBtfqbZoi9EFFxOoiUMWssceTqVbvsVG8j27Z03KMo9Y5L/9ajB26aehW+DoFqaS1PQr8y1r0SypZ+b3FL0fFeCvUAmYxL4vWWWoH5jvrb36wdEWIwF4rr9lDn8ipkUkvfjtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DUjfLTjPKkm5MbP4Mn6W6X79x4eMXZ1G/HuE+f5hrl8=; b=uvPzoPulIfGRGm+0SstCfu636n2Z/GZiPkyhAWrtXsDIJvOVzFloAC8zcpSKrloNtFT7gmSF2Q0dmYzBtZL/okc1Sqts9Dz6+8yP5zDYoXYP8CrQmiz+X4NHYqIxxD/AQVOR+PElRV6cariIrrlMaqTIfOYwJoMbDPF40p/kpP8= Received: from MW3PR05CA0005.namprd05.prod.outlook.com (2603:10b6:303:2b::10) by DS0PR12MB7945.namprd12.prod.outlook.com (2603:10b6:8:153::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar 2023 21:58:19 +0000 Received: from CO1NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::81) by MW3PR05CA0005.outlook.office365.com (2603:10b6:303:2b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29 via Frontend Transport; Wed, 15 Mar 2023 21:58:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT054.mail.protection.outlook.com (10.13.174.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6178.31 via Frontend Transport; Wed, 15 Mar 2023 21:58:18 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 15 Mar 2023 16:58:17 -0500 From: "Roth, Michael" To: CC: Tom Lendacky , Jiewen Yao , , Gerd Hoffmann , Erdem Aktas , James Bottomley , Min Xu Subject: [PATCH RESEND 0/4] Fixes for SEV-SNP CC blob and CPUID table handling Date: Wed, 15 Mar 2023 16:57:43 -0500 Message-ID: <20230315215747.1543837-1-michael.roth@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Return-Path: Michael.Roth@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT054:EE_|DS0PR12MB7945:EE_ X-MS-Office365-Filtering-Correlation-Id: b214465a-b610-46f0-02d1-08db25a06306 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PCGQDKrIBQgLoc8wjGzrsmyK5ETY3GMlXmLRqeo1Z0XGhyKo62Elzmxw/6JRUOLHoH1/dHtKL38iWbfHVlx4z3BqCB5V6SCfaazB6qa2RVqN6kpGU7I5k7EaMxTomdBART8uhFHnTZkyyvJ9oLQvM4v6TPPjo1RQeEKUiJxwaikS5X2g0OgQdbHtnthtCERH9oHJlCOlGkZOmvVp2qsTuDgFnLdrL8E2TpRKPaMJ4WcPCjxFofshnG+zrXP0gnpJhxIWyDFrFQIQPoGdMqQrcnuUsptw1zh8Gs59JgWtYNrmkPX2epm0Gt7Moyq5COiJp8QnStksu3QZt5NPdqNacL61eTAmTX0GtpKCD/knOiLxpkqdsQVN0yuLc6ZXUjo8gu3Cs7y3OHr7qyBpC65Z6xUCFrr3VAte05XgRZJfPJ9GSmxuBcnfALQSogAdSUBkFoAqrbIDYM4AwgQZuz7qQsHVtTDC0DNDSL0WFey4+SJ65Y8JNnFf2TeTmKp6vsl7HHLrb9hHg2Uqz802tC11IA0xceSG+gnnULFho1xEfj9fLnV+3N/d42ZYHm7iUOEqq/JGs9wC6sEd3P3MXggFMaBjYBUdKZV/PWNgybSO8phUQJbg8NfraSCYdOY2KefX5AJXv6K7bpxPehRmz/ehF9VsuEK3HApm8orzebtHfx/dXN9DZ+A4m5zimC2VAyyoIgbmQzlVr4JYI0QxVykG03DrJx9UTA03uYnji6X7LuQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(39860400002)(346002)(136003)(451199018)(36840700001)(46966006)(40470700004)(356005)(36756003)(86362001)(36860700001)(82740400003)(81166007)(41300700001)(8936002)(2906002)(5660300002)(26005)(82310400005)(40460700003)(4326008)(2616005)(40480700001)(1076003)(47076005)(186003)(16526019)(83380400001)(336012)(316002)(54906003)(426003)(70206006)(70586007)(8676002)(6666004)(6916009)(44832011)(478600001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 21:58:18.6109 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b214465a-b610-46f0-02d1-08db25a06306 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7945 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain (Rebased series and resending due to merge conflict with previous submission.) Here are a number of fixes related to OVMF handling of the SEV-SNP Confidential Computing blob and CPUID table. Patch #1 is a fix for recently-reported issue that can cause significant problems with some SEV-SNP guest operating systems. Please consider applying this patch directly if the other patches in this series are held up for any reason. Patches 2-4 are minor changes for things that aren't currently triggered in practice, but make OVMF's SEV-SNP implementation more robust for different build/hypervisor environments in the future. Patch #2 was submitted previously, but refreshed here to apply cleanly on top of Patch #1, with no other functional changes since the initial review. ---------------------------------------------------------------- Michael Roth (4): OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definitio= n OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP OvmfPkg/AmdSevDxe/AmdSevDxe.c | 64 ++++++++++++++= ++++++++++++++++++++++++++++++++++++-------------- OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h | 6 ++++-- OvmfPkg/Library/CcExitLib/CcExitVcHandler.c | 13 +++++-------- 3 files changed, 59 insertions(+), 24 deletions(-)