From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.17664.1679055567785610956 for ; Fri, 17 Mar 2023 05:19:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IJDQjC+T; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679055566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SHO/xodYVlXVBrhduvKpWr7lijbS95MyLSkWq5hj5nA=; b=IJDQjC+TT+ucNJkmN2800Iw/1zWdGv2j33ZNOfSQFnUir/jF4rdbLHzVKL+elqaAcrtXCP CZLIX6pS8brljp/SF55PV5hQbAlkURf8pSXjSd21svdBDC2ZDiGSACrUIsI8M2zoDj4dk1 9oi4ihfd+vRSz0XrkkUUsnnyU3YhWEE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-44-78aXwCqHNX-2VllIhMX_LQ-1; Fri, 17 Mar 2023 08:19:23 -0400 X-MC-Unique: 78aXwCqHNX-2VllIhMX_LQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4CB0538288A5; Fri, 17 Mar 2023 12:19:23 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 03C96C15BA0; Fri, 17 Mar 2023 12:19:22 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BD6F31800617; Fri, 17 Mar 2023 13:19:21 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Pawel Polawski , Oliver Steffen , Gerd Hoffmann , Jordan Justen , Jiewen Yao , Ard Biesheuvel Subject: [PATCH 1/1] OvmfPkg/PlatformBootManagerLib: use utf8 for the serial console. Date: Fri, 17 Mar 2023 13:19:21 +0100 Message-Id: <20230317121921.219205-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Time to leave behind relics from the last century and arrive in the modern world. Drop PC-ANSI Terminal Type for the serial console, use UTF-8 instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 4 ++-- OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h index 1676d61616d8..18b3deb9db59 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h @@ -126,7 +126,7 @@ extern VENDOR_DEVICE_PATH gTerminalTypeDeviceNode; 1 \ } -#define gPcAnsiTerminal \ +#define gVtUtf8Terminal \ { \ { \ MESSAGING_DEVICE_PATH, \ @@ -136,7 +136,7 @@ extern VENDOR_DEVICE_PATH gTerminalTypeDeviceNode; (UINT8) ((sizeof (VENDOR_DEVICE_PATH)) >> 8) \ } \ }, \ - DEVICE_PATH_MESSAGING_PC_ANSI \ + DEVICE_PATH_MESSAGING_VT_UTF8 \ } #define gEndEntire \ diff --git a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c index 6536d9fe369e..c1801725c2c8 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c +++ b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c @@ -47,7 +47,7 @@ typedef struct { ACPI_HID_DEVICE_PATH gPnpPs2KeyboardDeviceNode = gPnpPs2Keyboard; ACPI_HID_DEVICE_PATH gPnp16550ComPortDeviceNode = gPnp16550ComPort; UART_DEVICE_PATH gUartDeviceNode = gUart; -VENDOR_DEVICE_PATH gTerminalTypeDeviceNode = gPcAnsiTerminal; +VENDOR_DEVICE_PATH gTerminalTypeDeviceNode = gVtUtf8Terminal; // // Platform specific keyboard device path @@ -83,7 +83,7 @@ VENDOR_UART_DEVICE_PATH gDebugAgentUartDevicePath = { 0, // Parity - Default 0, // StopBits - Default }, - gPcAnsiTerminal, + gVtUtf8Terminal, gEndEntire }; @@ -168,7 +168,7 @@ STATIC VENDOR_UART_DEVICE_PATH gXenConsoleDevicePath = { FixedPcdGet8 (PcdUartDefaultParity), FixedPcdGet8 (PcdUartDefaultStopBits), }, - gPcAnsiTerminal, + gVtUtf8Terminal, gEndEntire }; -- 2.39.2