From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.7471.1679290475232002420 for ; Sun, 19 Mar 2023 22:35:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QmsxGPqg; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679290502; x=1710826502; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=r9qYsnqm77cfB3nqnod1PmANZY1lPOvn1miTTV5mMgw=; b=QmsxGPqgIbjtxBefwLezhPZFGIK0X7ah+IPJb2fEZRxi5rbAlIQxlHbO R5aFkg51AltHHfv81abFErP5JgfRZ0NKfYXrZ4f7LUlhzXRQYSzwDeeob xNOB2P9gNmnbXuCSibBSOEZ5RYRpz7TDRyDpbaH/sJ552IRGNKME7fOFA qn1w77rodJ63VNqahH/6a0isQGyccyy3PncM/8Xs6vFKr6xAESBI5TBoJ B9dCmA+V7ca2YfkOWW6FeRsQhoZHpu/PID9azC1sXEP37qyeM3c/NoN3w JVe0c2Ni8ARmh8nitNnBbhc3TveJuBdqFlono0WMjl4rYFVySOXtrnE4s w==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="401155741" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="401155741" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2023 22:35:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="770059630" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="770059630" Received: from shwdeopenlab702.ccr.corp.intel.com ([10.239.55.92]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2023 22:35:00 -0700 From: "duntan" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann Subject: [Patch V3 15/18] UefiCpuPkg/MpInitLib: Add code to initialize MapMask to 0 Date: Mon, 20 Mar 2023 13:33:26 +0800 Message-Id: <20230320053329.410-16-dun.tan@intel.com> X-Mailer: git-send-email 2.31.1.windows.1 In-Reply-To: <20230320053329.410-1-dun.tan@intel.com> References: <20230320053329.410-1-dun.tan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In function CreatePageTable(), Add code to initialize MapMask to 0. Missing the initialization doesn't cause functionality issue but looks confusing. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c b/UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c index 05a40bb225..b631e82836 100644 --- a/UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c +++ b/UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c @@ -37,6 +37,7 @@ CreatePageTable ( MapAttribute.Bits.Present = 1; MapAttribute.Bits.ReadWrite = 1; + MapMask.Uint64 = 0; MapMask.Bits.PageTableBaseAddressLow = 1; MapMask.Bits.Present = 1; MapMask.Bits.ReadWrite = 1; -- 2.31.1.windows.1